mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-12-22 12:02:46 +00:00
190962cc5b
An "advanced" option was first introduced in 2014 via patch I374805e (originally named "monitor-or-edit", renamed via patch I7b4f6d2). The isNavPopupsEnabled() function was added in 2016 via patch Ic660f48. The code that disables the extension entirely the moment the NavPopups gadget is enabled was added in 2017 via patch Ia474b1b (T151058) and patch Ia837816 (T160081). As of now, the "advanced" option can only be seen in an extreme edge case: * Only for anonymous users. * Only if NavPopups is enabled by default for anonymous users. * Only if the $wgPopupsConflictingNavPopupsGadgetName setting is misconfigured. * … or if NavPopups is not a gadget in the first place, but e.g. loaded via Common.js. In this situation the settings dialog opens with all *3* options. This is broken for several reasons: * The "simple" option enables the extension, but doesn't disable NavPopups. Both trigger, resulting in both popups being displayed the same time. * Since "simple" is the default, this bogus behavior is the default for anonymous users. * The "off" option doesn't stick. Every time the settings dialog opens "advanced" is checked instead. * "Off" can't work anyway. There is no code to disable the gadget. * Only the "advanced" option "works", but more by accident. It's unclear how to fix this: * There is no code that does anything with the "advanced" option. It's not even stored. The behavior of the option is identical to "off". * The code appears as if "advanced" was meant to be shown instead of "off". I.e. anonymous users can only choose one of the popups, but not disable both. But there is no code to hide the "off" option. * The bug when both popups are displayed was fixed in 2017 via an entirely different mechanism. Re-introducing "advanced" does not only mean duplication, it's unclear how the 2 mechanisms are meant to work together. It really, really feels like this was just forgotten. Bug: T278949 Change-Id: Iab21f3a649a5b2f19ebb0d0dbb45ce1450c65678
41 lines
3.5 KiB
JSON
41 lines
3.5 KiB
JSON
{
|
|
"@metadata": {
|
|
"authors": []
|
|
},
|
|
"popups-message": "Previews",
|
|
"popups-desc": "Displays preview popups when the user hovers over a link",
|
|
"popups-settings-title": "Page preview",
|
|
"popups-settings-unified-title": "Previews",
|
|
"popups-settings-option-simple": "Enable",
|
|
"popups-settings-option-simple-description": "Get quick previews of a topic while reading a page.",
|
|
"popups-settings-option-unified-description": "Get quick previews of a topic or reference while reading.",
|
|
"popups-settings-option-off": "Disable",
|
|
"popups-settings-save": "Save",
|
|
"popups-settings-help-ok": "Done",
|
|
"popups-settings-cancel": "Cancel",
|
|
"popups-settings-help": "You can turn previews back on using a link in the footer of the page.",
|
|
"popups-settings-enable": "Enable previews",
|
|
"popups-settings-icon-gear-title": "Change page preview settings",
|
|
"popups-preview-no-preview": "There was an issue displaying this preview",
|
|
"popups-preview-footer-read": "Go to this page",
|
|
"popups-preview-disambiguation": "This title relates to more than one page",
|
|
"popups-preview-disambiguation-link": "View similar pages",
|
|
"prefs-reading": "Reading preferences",
|
|
"popups-prefs-optin": "Enable page previews (get quick previews of a topic while reading a page)",
|
|
"popups-prefs-disable-nav-gadgets-info": "You have to [[$1|disable the Navigation popups gadget]] in your Gadgets preferences to enable page previews.",
|
|
"popups-prefs-conflicting-gadgets-info": "Certain gadgets and other customizations may affect the performance of this feature. If you experience problems please review your gadgets and user scripts, including global ones.",
|
|
"popups-prefs-navpopups-gadget-conflict-info": "You have the [[$1|Navigation popups]] gadget enabled, so you won't see previews provided by this feature. Depending on your wiki, the gadget may have a slightly different name. If you continue to experience issues, please review your gadgets and user scripts, including global ones.",
|
|
"popups-prefs-reftooltips-gadget-conflict-info": "You have the [[$1|Reference Tooltips]] gadget enabled, so you won't see reference previews but will still see page previews. Depending on your wiki, the gadget may have a slightly different name. If you continue to experience issues, please review your gadgets and user scripts, including global ones.",
|
|
"popups-prefs-reftooltips-and-navpopups-gadget-conflict-info": "You have the [[$1|Navigation popups]] and [[$1|Reference Tooltips]] gadgets enabled, so you won't see previews provided by this feature. Depending on your wiki, the gadgets may have slightly different names. If you continue to experience issues, please review your gadgets and user scripts, including global ones.",
|
|
"popups-refpreview-reference": "Reference",
|
|
"popups-refpreview-book": "Book reference",
|
|
"popups-refpreview-journal": "Journal reference",
|
|
"popups-refpreview-news": "News reference",
|
|
"popups-refpreview-note": "Note",
|
|
"popups-refpreview-web": "Web reference",
|
|
"popups-refpreview-collapsible-placeholder": "This reference includes a graphic which does not fit in the preview.",
|
|
"popups-refpreview-user-preference-label": "Enable reference previews (get quick previews of a reference while reading a page)",
|
|
"popups-refpreview-beta-feature-message": "Reference Previews",
|
|
"popups-refpreview-beta-feature-description": "Show a preview of a reference by hovering over its footnote marker.\n\nPlease note: If you're using the [//en.wikipedia.org/wiki/Wikipedia:Tools/Navigation_popups Navigation popups] gadget or the [[mw:Special:MyLanguage/Reference Tooltips|Reference Tooltips]] gadget, you won't see reference previews."
|
|
}
|