mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-13 17:56:55 +00:00
67eb3b1dcf
Currently, the mw.eventLog.Schema class samples per pageview. However, we expect that if a user is bucketed for a session, then all EventLogging events logged during that session are in the sample. Moreover, loading the class in the way that we did - asynchronously, using mw.loader#using - introduced an issue where the eventLogging change listener would subscribe in the next tick of the JavaScript VM's event loop and miss the "pageLoaded" event being queued (see T167273). Changes: * Make the schema module follow the form of the statsvInstrumentation module, i.e. make it expose the #isEnabled method, and add the associated getEventLoggingTracker function. * Update the eventLogging change listener accept the tracker returned by getEventLoggingTracker. * Update/fix related JSDoc documentation. Bug: T167236 Bug: T167273 Change-Id: I4f653bbaf1bbc2c2f70327e338080e17cd3443d4 |
||
---|---|---|
.. | ||
dist | ||
ext.popups | ||
ext.popups.images |