mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-28 01:10:04 +00:00
56aeeccb0d
... the interaction. Following on from Iccba3c4c, LINK_CLICK shouldn't be considered the end of an interaction because the link or preview can still be abandoned by the user. Unlike ABANDON_END and LINK_DWELL, therefore, LINK_CLICK musn't destroy the interaction but indicate that no more events should be enqueued for the interaction. More concretely, if the user has clicked the link or the preview, then a "dwelledButAbandoned" or "dismissed" event shouldn't be logged. Changes: * Distinguish between "finalizing" and "closing" an interaction, where the latter is the current behavior of ABANDON_END, LINK_DWELL, and LINK_CLICK, in the eventLogging reducer and associated tests. * If the interaction is finalized, then either the "dwelledButAbandoned" or "dismissed" events shouldn't be logged. Bug: T162924 Change-Id: I09d8776da992053f89a77508e29a7cde3cfeeac6 |
||
|---|---|---|
| .. | ||
| changeListeners | ||
| gateway | ||
| preview | ||
| reducers | ||
| actions.test.js | ||
| changeListener.test.js | ||
| counts.test.js | ||
| integration.test.js | ||
| isEnabled.test.js | ||
| previewBehavior.test.js | ||
| schema.test.js | ||
| settingsDialog.test.js | ||
| statsvInstrumentation.test.js | ||
| stubs.js | ||
| userSettings.test.js | ||
| wait.test.js | ||