wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-09-24 02:39:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
Mirror of https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups
1049 commits 271 branches 0 tags 63 MiB
JavaScript 83.4%
PHP 11.3%
Less 4.9%
Shell 0.4%
Go to file
Sam Smith 568b7a09a1 rest: Always scale thumbnail's largest dimension 
... thumbnails.

A good example of the difference in behaviour of the PageImages API is
here <T156800#3087507>. The API defers to File#transform, which scales
the largest dimension of an image, not always the width, e.g. if an
image is 1000px x 2000px and the request is for a thumbnail "of 1800px",
then the thumbnail will be 900px x 1800px.

Bug: T156800
Change-Id: I64bc2244ee78a594298d8637233b0da1083700eb
2017-03-10 10:44:37 +00:00
doc Docs: Add adr about running QUnit tests in node 2017-03-08 08:59:56 -08:00
i18n Localisation updates from https://translatewiki.net. 2017-03-08 22:39:21 +01:00
images Directory structure should reflect the ResourceLoader definitions 2016-10-19 20:52:40 +00:00
includes Hygiene: Remove stubs files from browser qunit tests 2017-03-06 17:09:15 +01:00
resources rest: Always scale thumbnail's largest dimension 2017-03-10 10:44:37 +00:00
src rest: Always scale thumbnail's largest dimension 2017-03-10 10:44:37 +00:00
tests rest: Always scale thumbnail's largest dimension 2017-03-10 10:44:37 +00:00
.eslintrc.json Tooling: Begin to use webpack for JS code generation 2017-02-13 13:42:22 +01:00
.gitattributes Hygiene: Move build/ext.popups/ to src/ 2017-02-14 09:59:59 -08:00
.gitignore Add code coverage reports npm script 2017-03-03 13:34:33 +01:00
.gitreview Merge remote-tracking branch 'gerrit/mpga' 2017-02-14 11:20:17 -08:00
.istanbul.yml Add code coverage reports npm script 2017-03-03 13:34:33 +01:00
.stylelintrc Remove jshint/jscs, add eslint and stylelint 2016-12-16 13:35:34 +01:00
composer.json build: Updating development dependencies 2016-01-05 10:39:25 -08:00
COPYING Add COPYING file 2014-02-06 15:38:46 +05:30
extension.json Specify es5-shim as a dependency 2017-03-03 11:54:30 +01:00
Gemfile Update mediawiki_api gem to 1.7.1 2016-05-26 01:34:35 +02:00
Gemfile.lock Hygiene: Remove RL-related step 2016-12-13 14:46:03 +00:00
Gruntfile.js Hygiene: Move build/ext.popups/ to src/ 2017-02-14 09:59:59 -08:00
jsduck.json Setup jsduck to run on 'npm run doc' 2015-08-03 15:54:25 +05:30
package.json Tooling: Use latest stable webpack 2017-03-08 19:27:40 +01:00
Popups.php Add extension.json, empty php entry point 2015-07-02 22:19:24 +00:00
README.md Add code coverage reports npm script 2017-03-03 13:34:33 +01:00
webpack.config.js Tooling: Use latest stable webpack 2017-03-08 19:27:40 +01:00

README.md

mediawiki/extensions/Popups

See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.

Development

Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.

You can find the frontend source files in src/, the compiled sources in resources/dist/, and other frontend assets managed by resource loader in resources/*.

After an npm install:

  • On one terminal, kickstart the bundler process:
    • npm start Will run the bundler in watch mode, re-assembling the files on file change.
    • npm run build Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
  • On another terminal, run tests and linting tools:
    • npm test To run the linting tools and the tests.
      • You can find the QUnit tests that depend on running MediaWiki under tests/qunit/
      • You can find the isolated QUnit tests under tests/node-qunit/, which you can run with npm run test:node
    • We recommend you install a file watcher like nodemon to watch sources and auto run linting and tests.
      • npm install -g nodemon
      • Example running linting and node unit tests:
        • nodemon -w src/ --exec "grunt lint:all && npm run test:node"
    • Get code coverage report with npm run coverage
      • Reports printed in the coverage/ folder