mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-17 20:41:32 +00:00
e6081106f1
Why: Because they are the approved standard by TC39 and Ecma for
JavaScript modules.
Changes:
* Wrap mw-node-qunit in run.js to register babel to transpile modules
for node v6
* Change all sources in src/ to use ES modules
* Change constants.js to be able to run without
jQuery.bracketedDevicePixelRatio given ES modules are hoisted to
the top by spec so we can't patch globals before importing it
* Change all tests in tests/node-qunit/ to use ES modules
* Drop usage of mock-require given ES modules are easy to stub with
sinon
Additional changes:
* Rename tests/node-qunit/renderer.js to renderer.test.js to follow
the convention of all the other files
* Make npm run test:node run only .test.js test files so that it
doesn't run the stubs.js or run.js file.
Bug: T171951
Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941
40 lines
809 B
JavaScript
40 lines
809 B
JavaScript
import createExperiments from '../../src/experiments';
|
|
|
|
QUnit.module( 'ext.popups/experiments#weightedBoolean' );
|
|
|
|
QUnit.test( 'it should call mw.experiments#getBucket', function ( assert ) {
|
|
var getBucketStub = this.sandbox.stub(),
|
|
stubMWExperiments = {
|
|
getBucket: getBucketStub
|
|
},
|
|
experiments = createExperiments( stubMWExperiments );
|
|
|
|
experiments.weightedBoolean( 'foo', 0.2, 'barbaz' );
|
|
|
|
assert.ok( getBucketStub.calledOnce );
|
|
assert.deepEqual(
|
|
getBucketStub.getCall( 0 ).args,
|
|
[
|
|
{
|
|
enabled: true,
|
|
|
|
name: 'foo',
|
|
buckets: {
|
|
'true': 0.2,
|
|
'false': 0.8 // 1 - 0.2
|
|
}
|
|
},
|
|
'barbaz'
|
|
]
|
|
);
|
|
|
|
// ---
|
|
|
|
getBucketStub.returns( 'true' );
|
|
|
|
assert.ok(
|
|
experiments.weightedBoolean( 'foo', 0.2, 'barbaz' ),
|
|
'It should return true if the bucket is "true".'
|
|
);
|
|
} );
|