mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-18 04:51:29 +00:00
c9d325d01e
Tests are basically unchanged, except for some stubs on beforeEach. Supporting changes: * Bring stubs from the mediawiki library for mw.Uri, mw.Title.newFromText and mw.RegExp into stubs.js * Remove hook onResourceLoaderTestModules given there are no resource loader test modules after migrating processLinks.test.js Why bring stubs from real source? This is not optimal. It could be the case that the stubs would need to be updated at some point in the future. That's why in the comment of each stub, it is specified where it came from, and what was changed to make it work. It is not optimal but it should help with a future update if necessary. Also checked the history of the stubs and these three stubs are very stable with a small commits per year, usually adding some extra functionality (not breaking changes) (the rest of the commits are docs/format stuff), so the core behavior that we rely on here shouldn't change in a fundamental way. See the github links: * https://github.com/wikimedia/mediawiki/commits/master/resources/src/mediawiki/mediawiki.Uri.js * https://github.com/wikimedia/mediawiki/commits/master/resources/src/mediawiki/mediawiki.Title.js * https://github.com/wikimedia/mediawiki/commits/master/resources/src/mediawiki/mediawiki.RegExp.js Right now this stubs allow us to bring the test to run in isolation in node. The initial plan was to do change the test to be less test-case oriented with dependencies on mediawiki.*.js and not to bring fake "real" stubs, but after looking into it, given that: 1. the test cases in the test seem pretty informative showing the kind of links that popups accepts 2. the stubs are acceptably easy to bring in, and are pretty stable I decided to go with this approach initially to finish the migration without changing the meaning of the tests. If we want to remove the stubs and morph the test to verify stub calls and move the test cases to documentation on the source, I'll tackle that on a future commit. Bug: T160406 Change-Id: Ieea378c9b7fec9116222b4a099c226d1f1131f65 |
||
|---|---|---|
| .. | ||
| PopupsContextTest.php | ||
| PopupsContextTestWrapper.php | ||
| PopupsGadgetsIntegrationTest.php | ||
| PopupsHooksTest.php | ||