mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-12 01:08:39 +00:00
2ca5fed3ee
The render change listener is hard coupled to the renderer file, so in order to migrate the test, instead of stubbing a global variable, we had to either inject the renderer into the change listener factory as done everywhere else, or mock the require call. In order to do one thing per commit, we're mocking the require call here to get the migration done, but added a FIXME to use dependency injection instead in a future change. Change-Id: I50f82cdc9664d34b8a8ccc1ff368f7209404159d |
||
---|---|---|
doc | ||
i18n | ||
images | ||
includes | ||
resources | ||
src | ||
tests | ||
.eslintrc.json | ||
.gitattributes | ||
.gitignore | ||
.gitreview | ||
.stylelintrc | ||
composer.json | ||
COPYING | ||
extension.json | ||
Gemfile | ||
Gemfile.lock | ||
Gruntfile.js | ||
jsduck.json | ||
package.json | ||
Popups.php | ||
README.md | ||
webpack.config.js |
mediawiki/extensions/Popups
See https://www.mediawiki.org/wiki/Extension:Popups for more information about what it does.
Development
Popups uses an asset bundler so when developing for the extension you'll need to run a script to assemble the frontend assets.
You can find the frontend source files in src/
, the compiled sources in
resources/dist/
, and other frontend assets managed by resource loader in
resources/*
.
After an npm install
:
- On one terminal, kickstart the bundler process:
npm start
Will run the bundler in watch mode, re-assembling the files on file change.npm run build
Will compile the assets just once, ready for deployment. You must run this step before sending the patch or CI will fail (so that sources and built assets are in sync).
- On another terminal, run tests and linting tools:
npm test
To run the linting tools and the tests.- You can find the QUnit tests that depend on running MediaWiki under
tests/qunit/
- You can find the isolated QUnit tests under
tests/node-qunit/
, which you can run withnpm run test:node
- You can find the QUnit tests that depend on running MediaWiki under
- We recommend you install a file watcher like
nodemon
to watch sources and auto run linting and tests.npm install -g nodemon
- Example running linting and node unit tests:
nodemon -w src/ --exec "grunt lint:all && npm run test:node"