mirror of
https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups
synced 2024-11-28 17:30:26 +00:00
d07441ec7f
Under some unknown circumstances getPreviewCountBucket() is called with a value that is not a -1 or a natural number. When that happens function returns 'undefined bucket' which causes eventLogging to fail. I wasn't able to reproduce the issue, it might be specific to browser/os. The safest way is to return 'unknown' for any other case. Bug: T168371 Change-Id: I374bb629762a86ac06a18e775d3c1a14682c9f55
70 lines
1.6 KiB
JavaScript
70 lines
1.6 KiB
JavaScript
import * as counts from '../../src/counts';
|
|
|
|
QUnit.module( 'ext.popups/counts' );
|
|
|
|
QUnit.test( '#getEditCountBucket', function ( assert ) {
|
|
var i, bucket, count,
|
|
cases = [
|
|
[ 0, '0 edits' ],
|
|
[ 1, '1-4 edits' ],
|
|
[ 2, '1-4 edits' ],
|
|
[ 4, '1-4 edits' ],
|
|
[ 5, '5-99 edits' ],
|
|
[ 25, '5-99 edits' ],
|
|
[ 50, '5-99 edits' ],
|
|
[ 99, '5-99 edits' ],
|
|
[ 100, '100-999 edits' ],
|
|
[ 101, '100-999 edits' ],
|
|
[ 500, '100-999 edits' ],
|
|
[ 999, '100-999 edits' ],
|
|
[ 1000, '1000+ edits' ],
|
|
[ 1500, '1000+ edits' ]
|
|
];
|
|
|
|
assert.expect( cases.length );
|
|
|
|
for ( i = 0; i < cases.length; i++ ) {
|
|
count = cases[ i ][ 0 ];
|
|
bucket = counts.getEditCountBucket( count );
|
|
assert.equal(
|
|
bucket,
|
|
cases[ i ][ 1 ],
|
|
'Edit count bucket is "' + bucket + '" when edit count is ' + count + '.'
|
|
);
|
|
}
|
|
} );
|
|
|
|
QUnit.test( '#getPreviewCountBucket', function ( assert ) {
|
|
var i, count, bucket,
|
|
cases = [
|
|
[ false, 'unknown' ],
|
|
[ NaN, 'unknown' ],
|
|
[ undefined, 'unknown' ],
|
|
[ null, 'unknown' ],
|
|
[ '', 'unknown' ],
|
|
[ -1, 'unknown' ],
|
|
[ 0, '0 previews' ],
|
|
[ 1, '1-4 previews' ],
|
|
[ 2, '1-4 previews' ],
|
|
[ 4, '1-4 previews' ],
|
|
[ 5, '5-20 previews' ],
|
|
[ 10, '5-20 previews' ],
|
|
[ 20, '5-20 previews' ],
|
|
[ 21, '21+ previews' ],
|
|
[ 100, '21+ previews' ],
|
|
[ 1000, '21+ previews' ]
|
|
];
|
|
|
|
assert.expect( cases.length );
|
|
|
|
for ( i = 0; i < cases.length; i++ ) {
|
|
count = cases[ i ][ 0 ];
|
|
bucket = counts.getPreviewCountBucket( count );
|
|
assert.equal(
|
|
bucket,
|
|
cases[ i ][ 1 ],
|
|
'Preview count bucket is "' + bucket + '" when preview count is ' + count + '.'
|
|
);
|
|
}
|
|
} );
|