Jon Robson 2c09fd1d1c Generalize settings code (attempt 2) ... This reverts commit a6a65204c6. to restore custom preview types. -- Changes since revert The previous patch accidentally removed the syncUserSettings changeListener. This has now been restored with several modifications: * We have a migrate script which rewrites existing localStorage settings to the new system * The existing save functions are generalized. The changes since this patch are captured in Ia73467799a9b535f7a3cf7268727c9fab7af0d7e -- More information A new REGISTER_SETTING action replaces the BOOT action for registering settings. This allows custom preview types to be associated with a setting. They do this by adding the enabled property to the module they provide to mw.popups.register Every time the new action is called, we refresh the settings dialog UI with the new settings. Previously the settings dialog was hardcoded, but now it is generated from the registered preview types by deriving associated messages and checking they exist, so by default custom types will not show up in the settings. Benefits: * This change empowers us to add a setting for Math previews to allow them to be enabled or disabled. * Allows us to separate references as its own module Additional notes: * The syncUserSettings.js changeListener is no longer needed as the logic for this is handled inside the "userSettings" change listener in response to the "settings" reducer which is responding to SETTINGS_CHANGE and REGISTER_SETTING actions. Upon merging: * https://www.mediawiki.org/wiki/Extension:Popups#Extensibility will be updated to detail how a setting can be registered. Bug: T334261 Bug: T326692 Change-Id: Ie17d622870511ac9730fc9fa525698fc3aa0d5b6		2024-01-09 17:24:09 -08:00
..
nextState.test.js	build: Update eslint-config-wikimedia to 0.22.1	2022-02-28 13:18:24 +00:00
pageviews.test.js	build: Update eslint-config-wikimedia to 0.22.1	2022-02-28 13:18:24 +00:00
preview.test.js	build: Update eslint-config-wikimedia to 0.22.1	2022-02-28 13:18:24 +00:00
settings.test.js	Generalize settings code (attempt 2)	2024-01-09 17:24:09 -08:00
statsv.test.js	Remove Popups instrumentation	2021-07-29 17:01:01 +00:00