9 commits

Author	SHA1	Message	Date
Piotr Miazga	4684b39841	Hygiene: use actionsTest consts instead of hardcoded states ... The unit tests should use defined action types instead of hardcoding each state. Change-Id: I6769ba057e93239e1c720c3bfa050c618ea63978	2018-07-13 17:12:49 +02:00
Stephen Niedzielski	ae44042cbf	Hygiene: add assertion messages ... Change-Id: Ic0a47bd468532824e8648c3f6371cc403896603c	2018-05-08 15:55:23 -05:00
Stephen Niedzielski	57762e0417	Hygiene: favor const ... Bug: T165036 Change-Id: I17d374eaac6627ca6a8ba178862b2a9cff2538c0	2018-03-21 10:44:24 +00:00
Stephen Niedzielski	0bee0906d4	Hygiene: replace var with let and const ... eslint \ --cache \ --max-warnings 0 \ --report-unused-disable-directives \ --fix \ src tests Change-Id: I051275126ae7fa9affd16c2504017c0584f2d9c7	2018-03-20 14:14:02 -05:00
Stephen Niedzielski	ece4670710	Hygiene: use arrow for anonymous functions ... In some places, the arrow function seems more natural. This patch approximates the following with manual amendments: find \ -not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \ -iname \*.js| xargs -rd\\n sed -ri 's%function\s*(\([^)]*\))%\1 =>%g' Files to focus on were identified with: rg -slg\!/resources/dist/ -g\!/i18n/ -g\!/doc/ 'this|self|arguments|bind|call|apply|new'| xargs -rd\\n git difftool -y Bug: T165036 Change-Id: Ic66b6000b8fc000f9bfde39749f9cfa69924a13c	2018-03-20 09:27:08 -05:00
Stephen Niedzielski	a67466acc0	Hygiene: replace obvious function methods ... Replace easily identifiable object functions with method syntax: find \ -not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \ -iname \*.js| xargs -rd\\n sed -ri 's%:\s*function\s*(\([^)]*\))%\1%g' Bug: T165036 Change-Id: I90693ee99a6a36dff820dd5ae6f6000429763058	2018-03-20 09:27:07 -05:00
jdlrobson	535149c16c	Upgrade schema and log the required fields ... This change updates the schema and begins to log additional information such as source_namespace, id and title. This information is provided inside the boot action. Additional changes: * Allow camel case in bundle artifact Bug: T184793 Bug: T186728 Change-Id: I425ffecc018bef2958d0dfe957a40a065e3e6c56	2018-02-26 10:25:30 -08:00
Sam Smith	35daa2a689	Hygiene: Page view -> Pageview ... Pageview is consistent with verbiage used by Research and Analytics Engineering in their reports and documentation, e.g. https://wikitech.wikimedia.org/wiki/Analytics/Pageviews. Bug: T184793 Change-Id: I8ae085b4af85aa72f234f3db27f0cac2c4d014e5	2018-02-21 18:51:49 +00:00
jdlrobson	a702c0f499	Capture page view-like interactions ... * New action added PREVIEW_SEEN * The action will be used to signal that a page view needs to be recorded. * PREVIEW_SEEN is a delayed action which is triggered as a side-effect of the previewShow action. It is only dispatched if the user is still previewing the same card and the page related to the card has preview type `page` * The pageview changelistener is added when $wgPopupsVirtualPageViews is set to true. * The page view changelistener listens for page views and logs them using EventLogging when needed using https://meta.wikimedia.org/wiki/Schema:VirtualPageView Note: * Currently if a user has enabled the DNT header, the event will not be logged. There is ongoing discussion on the ticket and fixing this will be addressed separately. * Only title and referrer are logged in the initial version. The task demands that "namespace" is logged but this information is not provided by the summary endpoints we use so will need to be added later (if indeed needed) either via a change to that endpoint of by using JavaScript to parse the URL. Bug: T184793 Change-Id: Id1fe34e4bdada3a41f0d888a753af366d4756590	2018-02-16 23:03:33 +00:00