54 commits

Author	SHA1	Message	Date
Piotr Miazga	05eccb31c1	Hygiene: use UserGetDefaultOptions instead of ExtensionRegistration ... Changes: - removed onExtensionRegistration and related TODOs - introduced onUserGetDefaultOptions hook Change-Id: I6648802c19d90df36a211d6494033aca30c078ca	2017-01-10 18:34:43 +01:00
Piotr Miazga	c3cfcbe0e0	Inject preference option directly after skin select ... Per #Design's mocks, the "Reading preferences" section should appear immediately beneath the Skin section, if it's present. Changes: - onGetPreferences will try to inject PagePreviews option after skin section or on the end of section when skin select is not available - unit tests for new behaviour Bug: T146889 Change-Id: Id14c0774aee917b7e949ab3ba5968a038b3ca933	2016-12-21 16:53:33 +00:00
Piotr Miazga	c587a9785b	Hygiene: Improve code quality by reaching 100% coverage ... Changes: - added missing unit tests - introduced PopupsContextTestWrapper, removed all unit-tests logic from Hooks/Context classes - removed getModule() from Popups.hooks.php, it's hooks responsibility to keep single context instance - removed class_exists calls, use ExtensionRegistry instead - pass ExtensionRegistry as a dependency so it's easy to mock - reach 100% code coverage - introduce PoupsContext::isBetaOn() as it was used in many places Change-Id: Id014efe72edf24628539c76968e53eb3e06709f4	2016-12-21 16:03:33 +01:00
Piotr Miazga	959bf40d9b	Implement necessary wiring for preferences ... Changes: - introduce unit tests - don't send module for anonymous users - renamed Module to Context - remove Config dependency from Popups.hooks.php Bug: T146889 Change-Id: I3cbcdc1303411b28b613afa6dd1a00b410891471	2016-12-20 16:54:33 +01:00