4 commits

Author	SHA1	Message	Date
Kunal Mehta	ba9e3c68f6	build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 ... The following sniffs are failing and were disabled: * MediaWiki.Commenting.FunctionComment.MissingParamComment * MediaWiki.Commenting.FunctionComment.MissingParamTag * MediaWiki.Commenting.FunctionComment.MissingReturn * MediaWiki.Commenting.FunctionComment.ParamNameNoMatch * MediaWiki.FunctionComment.Missing.Public * MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment Change-Id: Id9e98b7a4e87d00c63e7b509506c23f12cf0d380	2017-06-20 00:19:34 -07:00
Piotr Miazga	c13ab30bfa	Move conflicting NavPopups gadget name into config var ... Changes: - removed hardcoded comflicting Navigation Popups gadget name - introduced a config variable to specify conflicting gadget name Bug: T151058 Change-Id: Ief5c6f90ec6dd6c074931f7d9ff20297d4718fe5	2017-01-12 18:07:20 +01:00
Piotr Miazga	211f1d1658	Disable Page Previews preferences when NavPopups are enabled ... Changes: - introduced PopupsGadgetsIntegration class handles all checks - show help message on Preferences page when NavPopups is enabled - unit test everything Bug: T151058 Change-Id: Ia474b1b30378efe84dedf3ad47c1f833e88d69b5	2017-01-11 01:06:48 +01:00
Piotr Miazga	c587a9785b	Hygiene: Improve code quality by reaching 100% coverage ... Changes: - added missing unit tests - introduced PopupsContextTestWrapper, removed all unit-tests logic from Hooks/Context classes - removed getModule() from Popups.hooks.php, it's hooks responsibility to keep single context instance - removed class_exists calls, use ExtensionRegistry instead - pass ExtensionRegistry as a dependency so it's easy to mock - reach 100% code coverage - introduce PoupsContext::isBetaOn() as it was used in many places Change-Id: Id014efe72edf24628539c76968e53eb3e06709f4	2016-12-21 16:03:33 +01:00