wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-12-14 16:32:07 +00:00
Code Issues Packages Projects Releases Wiki Activity
2711 commits 13 branches 16 tags 70 MiB
Commit graph

2711 commits

This branch
This branch
All branches
Author SHA1 Message Date
Volker E b8cf442f85 Add standard transition to settings icon 
Change-Id: Ia04b179005a8bedde896c33f2cd230e1014e7de6
 2019-12-18 17:33:39 -08:00
jenkins-bot 635c37903e Merge "Simplify Hooks section in extension.json" 2019-12-18 10:31:58 +00:00
jenkins-bot 5d925e3479 Merge "Add tests case for user preferences while in Beta mode" 2019-12-18 07:57:40 +00:00
Thiemo Kreuz 776f4af6c5 Add tests case for user preferences while in Beta mode 
This is a direct follow up for I4d31805. Note the previous patch was
only testing the code path when Beta is disabled. But the bug was about
what happens when Beta is enabled. This is now properly covered by
these tests.

Bug: T240947
Change-Id: I54c5e9751e14a94808e85d935e1972eea0395002
 2019-12-17 16:27:26 +01:00
Thiemo Kreuz fc6a72094d Turn some tests into faster running "pure" unit tests 
On my local machine, this reduced the runtime for all PHPUnit tests
combined from 900ms to 800ms.

Change-Id: Iec4f0396115fd270ba1a1f6668e1672cea5f7aff
 2019-12-17 16:20:27 +01:00
Thiemo Kreuz 5752c2538e Fix initial preferences for newly created user accounts 
It appears like we accidentially copy-pasted the behavior for
PagePreviews and made ReferencePreviews behave the same, not taking
into account that the later feature is in Beta mode.

Bug: T240947
Change-Id: I4d31805ee9b2045c49c7ab4179c5a4adbcba0394
 2019-12-17 13:37:11 +00:00
Thiemo Kreuz dc60f44e87 Simplify Hooks section in extension.json 
It is possible, but very rare to have more than a single hook handler
per hook in a single extension. The value can be an array or string in
both version 1 and 2 of extension.json.

Change-Id: If3a7d89030b28b46e3601c63cda2b3fed14eb00c
 2019-12-17 11:49:00 +01:00
Translation updater bot 219c0c208b Localisation updates from https://translatewiki.net. 
Change-Id: I158bea73a9f94f237c5803323cc0a65d304cc389
 2019-12-16 12:14:59 +01:00
jdlrobson 1803ac5b2d Storybook: Images should be relative uris 
Follow up to I58493db15b27f148fcc1cf42ab0b0148ee291eb6

Bug: T236589
Change-Id: I305badda5a3f93684270bfe07d6cc19c92df3e07
 2019-12-13 01:42:13 +00:00
jdlrobson 24666442d5 Storybook: Copy over static files 
Follow up to  I58493db15b27f148fcc1cf42ab0b0148ee291eb6

Bug: T236589
Change-Id: I706107f80048a14a8122df503f53eb6936b95395
 2019-12-12 13:08:22 -08:00
jdlrobson 44239076af Use local files for storybook 
Currently images do not display on docs.wikimedia.org
These need to be local due to the security restrictions there.

Bug: T213223
Bug: T236589
Change-Id: I58493db15b27f148fcc1cf42ab0b0148ee291eb6
 2019-12-12 11:28:27 -08:00
jdlrobson 189b386a13 Publish storybook now we are using more modern node 
Breaking change - I was having issues getting the knobs feature
to work so it has been removed for the time being.

Bug: T236589
Depends-On: I8505d2dad69aefed5f8ed1f599b3ca1b7e79acf5
Change-Id: I42fbf37124477e2d950b4bca15acf77703cd3f5d
 2019-12-11 15:16:13 -08:00
Translation updater bot c6cf10ff1f Localisation updates from https://translatewiki.net. 
Change-Id: Id1828c3f140716f97baf4a6518f1e944267e1ba9
 2019-12-06 09:32:32 +01:00
Translation updater bot 685f27891e Localisation updates from https://translatewiki.net. 
Change-Id: Iddc99bdd74d01f046866feaece675ef95283dbe5
 2019-12-02 09:23:04 +01:00
Thiemo Kreuz 3051067029 Update extension.json to make use of PSR-4 
As far as I can see this codebase is already PSR-4 compatible. Let's
make use of it then.

Change-Id: I45a8492ce52d96acaf27e73d20e06e68de892686
 2019-11-27 10:12:03 +01:00
Ammar Abdulhamid 5fd286d1ee Update extension.json to use manifest_version 2 
Bug: T234114
Change-Id: I6a49f371fb69578e251bb5a0ecb6d9c0efe059d6
 2019-11-27 09:08:49 +00:00
Translation updater bot 012cfc650e Localisation updates from https://translatewiki.net. 
Change-Id: I761093a8e0e20e03c17586fffdc72f9c6868f219
 2019-11-22 09:15:15 +01:00
Translation updater bot d42d25335f Localisation updates from https://translatewiki.net. 
Change-Id: I1647f272d0d37abd58365c21c38142a626eb3dcf
 2019-11-20 09:38:32 +01:00
Translation updater bot 674efe154b Localisation updates from https://translatewiki.net. 
Change-Id: Ic43c41da567194def314187e8f3d0af51ddfe1d0
 2019-11-19 09:35:17 +01:00
jenkins-bot 4028e0b2da Merge "Don't record Popups actions on non-content pages" 2019-11-18 08:05:25 +00:00
Translation updater bot a352e01b79 Localisation updates from https://translatewiki.net. 
Change-Id: I6cf1b68fa31a2c17263b2be5f041f3ddce25cb14
 2019-11-15 09:22:03 +01:00
Adam Wight 07aa0f3ae9 Don't record Popups actions on non-content pages 
We found that Popups was overcounted approximately 2.5x relative to Cite.
This patch attempts to nearly match the circumstances under which Cite
(and its tracking) is loaded.

Bug: T214493
Change-Id: Ib31df3c33879f4ea63d9808ffd260861069a8977
 2019-11-14 16:52:05 +01:00
Translation updater bot 56224e5bd1 Localisation updates from https://translatewiki.net. 
Change-Id: I7980eecd5e527364c347fa768c6382da2b9d56fc
 2019-11-12 09:32:28 +01:00
Translation updater bot 726c2fdae9 Localisation updates from https://translatewiki.net. 
Change-Id: If7be94652e75e48499316b064167255a5f9524e8
 2019-11-11 14:51:02 +01:00
Adam Wight 0c1e628edb Ensure that pageviews are recorded at most once 
The Popups pageviews were suspiciously high, about 2.5x higher than
Cite counts which should have reported the same number.  This patch
attempts to deduplicate pageview events.

Bug: T214493
Change-Id: I51bf6d1909d65ecd9d3ef28eda285852897343ec
 2019-11-08 11:23:02 +01:00
Translation updater bot 09f36bfc25 Localisation updates from https://translatewiki.net. 
Change-Id: I178fd57b3d8f06def5757eada73212b741fdf9f8
 2019-11-07 09:44:51 +01:00
Translation updater bot 1d1d46c95e Localisation updates from https://translatewiki.net. 
Change-Id: Ifd59eb44a846a94b60ad183cfdd2f1543970e803
 2019-11-05 09:46:18 +01:00
Umherirrender 6f0e30e366 build: Updating mediawiki/mediawiki-phan-config to 0.8.0 
Bug: T235049
Change-Id: If095181a45ba845b230402fabfa338fa598f3833
 2019-11-04 18:48:36 +01:00
Translation updater bot 7d3fc222dd Localisation updates from https://translatewiki.net. 
Change-Id: Ic8187819cf1d56185756177f46cf9ace6ce8d50b
 2019-11-04 10:17:27 +01:00
Translation updater bot df8b880131 Localisation updates from https://translatewiki.net. 
Change-Id: I1417ab22f067d47892cc0e9e7307088514d6aedc
 2019-10-31 09:29:26 +01:00
jenkins-bot 4b9f1443c0 Merge "Localisation updates from https://translatewiki.net." 2019-10-30 10:57:33 +00:00
jenkins-bot 506f53118c Merge "Use standard size and fix alignment of generic reference icon" 2019-10-30 08:41:42 +00:00
Translation updater bot 51f70f3372 Localisation updates from https://translatewiki.net. 
Change-Id: I03a58298b6d05b2c3d466fb414b4ccebc78138e5
 2019-10-30 09:33:41 +01:00
Translation updater bot b05e65cb80 Localisation updates from https://translatewiki.net. 
Change-Id: I21d9d17bb214829cd7cb667abd75bc59508ed1ea
 2019-10-29 09:39:10 +01:00
Translation updater bot ab09d35728 Localisation updates from https://translatewiki.net. 
Change-Id: Ic7e6ab31399f1009ccaea22e22e664b0f2c2fbb6
 2019-10-28 16:35:51 +01:00
Volker E 80368fc1bd Use standard size and fix alignment of generic reference icon 
Using standard size of 20px for reference icon. This also brings
the icon into the right alignment to the text.

Bug: T221555
Change-Id: I5638a950b8e7fb0e1c1d116ed0755ddc8e25edc2
 2019-10-27 22:22:28 -07:00
Umherirrender a2e5bd0364 build: Remove unneeded Squiz.WhiteSpace.FunctionSpacing 
It is already part of the default ruleset.xml

Change-Id: I26ee0c4df83360577ef08b42d5f05084c6b29ea3
 2019-10-25 20:32:36 +02:00
jenkins-bot adcbf91237 Merge "Record pageviews where Reference Previews is enabled" 2019-10-25 08:12:06 +00:00
jenkins-bot 9d8291879a Merge "Inline eventlogging call" 2019-10-25 07:58:01 +00:00
Translation updater bot d0cd4e7ab6 Localisation updates from https://translatewiki.net. 
Change-Id: I8f1ec1249ed610c79c87d478c26a23b09ac84dd4
 2019-10-25 09:19:18 +02:00
Adam Wight b7331a6e66 Record pageviews where Reference Previews is enabled 
We want to know the side of this population in pageviews, in order to
produce proportional metrics later.

Bug: T214493
Change-Id: I940872870754e85d19688f3855d6857e65b982b1
 2019-10-24 23:34:56 +02:00
Adam Wight fed99e7cb5 Inline eventlogging call 
This isn't messy enough to justify encapsulation in a function.

Change-Id: Idfa6581d30709f1a58ff8c83ead08e1bfda81c1c
 2019-10-24 22:52:48 +02:00
Translation updater bot cb5ee37457 Localisation updates from https://translatewiki.net. 
Change-Id: Ifd0c6be2a50741ee2fedd4331d08ad8a2c4cabec
 2019-10-24 10:47:50 +02:00
jenkins-bot f67337c475 Merge "Use 6.1.0 of @wikimedia/mw-node-qunit" 2019-10-23 09:39:05 +00:00
Translation updater bot 0ddbe4e3f7 Localisation updates from https://translatewiki.net. 
Change-Id: I949b0bdce6a8273f4d37f9d52c2f6c1b823a2a46
 2019-10-23 09:53:33 +02:00
jdlrobson 01fc2db19f Use 6.1.0 of @wikimedia/mw-node-qunit 
Bug: T203137
Change-Id: I9fd701cc9575ad250c919d88bf1fe74898b690eb
 2019-10-22 10:42:49 -07:00
Adam Wight 171e1b7dbf Sample ReferencePreviewsPopups 1:1 
We're getting a few dozen records per day at 1:10, so let's stop sampling.
We need enough data to get significance on events happening at 0.1% or less.

Bug: T214493
Change-Id: I8a913fe1ee1e5b72d84914e183ac2386ddb20d84
 2019-10-22 12:14:17 +02:00
jenkins-bot 27381dd854 Merge "Make use of User::getBoolOption() where appropriate" 2019-10-22 08:09:39 +00:00
Thiemo Kreuz e5b36f6270 Make use of User::getBoolOption() where appropriate 
Bug: T233813
Change-Id: I804c34817e093fe7e507e5379647b52f187a686b
 2019-10-22 09:58:47 +02:00
jenkins-bot 3240a87898 Merge "Remove obsolete mediaWiki and jQuery aliases" 2019-10-22 07:46:07 +00:00