wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-18 21:05:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
1237 commits 279 branches 0 tags 65 MiB
Commit graph

16 commits

Author SHA1 Message Date
Piotr Miazga ef283c2509 Extract rendering/parsing mediawiki responses into separate class 
Page Previews should be able to consume HTML response generated by
MediaWiki. First we need to move out plain text crunching from
renderer.js and model.js. Mediawiki and Restbase gateways will have
to parse/htmlize plaintext into nice HTML by themselves.

Bug: T165018
Change-Id: I5d7e9f610bb809aa9fb035a4a9f96e9e8796c9d8
 2017-06-09 18:34:25 +02:00
Baha d6424cb59d QA: Test renderer#show 
Binding the behavior has been left out as it requires some refactoring.
Ideally, that functionality should be tested via integration tests, which
is already done.

Bug: T133022
Change-Id: If2fd472847eb3557de97c7ec9619e8831e9bda6d
 2017-05-09 17:15:01 -04:00
Baha 108f205e12 QA: Test renderer#layoutPreview 
Bug: T133022
Change-Id: I7b7aa544b850e5487a621c522b28653db6056633
 2017-05-09 17:13:16 -04:00
Baha 6d95bbf630 Refactor and test renderer#createLayout 
* Make function dependencies explicit;
* Only pass data that's needed, no more.

Bug: T133022
Change-Id: Ia973bd9636a477a76db907a37e2a0689daf4e3fa
 2017-05-05 14:20:46 -04:00
Baha da2e8c82b0 QA: Improve renderer#createThumbnail tests 
* Test for cases when a thumbnail won't be generated;
* Test thumbnail widths and heights;
* Test thumbnail coordinates.

Bug: T133022
Change-Id: I0f7d94816a2faab488b84f55b4462c8732d1031d
 2017-05-05 10:43:59 -04:00
Ed Sanders 81a6d49e99 build: Update eslint to 0.4.0 and make pass 
Change-Id: I7d301049f0c91f79e82f996b2dce770840c27e72
 2017-05-05 05:43:16 +01:00
Baha 0b169321d8 QA: Test renderer#bindBehavior 
Bug: T133022
Change-Id: I3b0b199010f0460d83f80c57e4bab8e3606a4b4f
 2017-05-04 15:48:10 -04:00
Baha d95badc614 QA: Test renderer#hide 
Bug: T133022
Change-Id: I752c4266b6be1909a3265d8292e7c5229e5724fb
 2017-05-03 13:26:19 -04:00
Baha 76d323da60 QA: Test renderer#createThumbnail 
Bug: T133022
Change-Id: Ia6f4de8cbb7ba3b389fb326007db0f859ae1d80a
 2017-05-03 13:24:54 -04:00
Baha eb9ceb6238 QA: Test renderer#createPreview 
Bug: T133022
Change-Id: Ied8e798851d5aebf2910aba5866f8a801c20923b
 2017-05-03 13:23:43 -04:00
Baha a46a5fc02f QA: Test renderer#createEmptyPreview 
Bug: T133022
Change-Id: If93d2c679bd7edcf98946e1cb688bc5c3744f69b
 2017-05-03 13:21:24 -04:00
Baha ccca8b7a90 QA: Test renderer#createThumbnailElement 
Bug: T133022
Change-Id: I7909c208e3d69b2ee510dcd8bfbcafc0118397ca
 2017-05-03 16:25:28 +00:00
Baha 7f89341cc6 QA: Test renderer#getClasses 
Bug: T133022
Change-Id: If3b8888a948f6e14d8847fdc1d4ea16e42329bb8
 2017-05-03 16:24:18 +00:00
Baha 872691e293 QA: Bring back renderer#renderExtract tests 
The tests were removed in Iae0a78d0b8a13353de70794b67387f2c3bab44c6.
The ultimate goal is to refactor the renderer code and make it
testable, but before doing so we need to add tests to cover the existing
code. This will give us confidence that we won’t accidentally break
anything when we refactor.

Some of the tests have been removed as the functionality covered by
those were moved to model.js in I20f29657fcf94101a71ed13c0920508db71292ce.

Bug: T133022
Change-Id: I7b20324dd5fe8a428cdd96959b65bc82d44fb515
 2017-05-02 12:09:11 -04:00
Baha 234282d1a2 QA: Test renderer#createPokeyMasks 
The ultimate goal is to refactor the renderer code and make it
testable, but before doing so we need to add tests to cover the existing
code. This will give us confidence that we won’t accidentally break
anything when we refactor.

Bug: T133022
Change-Id: I3ecbfb9bb3ac9c63fdd40df502796748c62949fe
 2017-05-01 11:00:42 -04:00
Baha 2030cb6b06 QA: Bring back renderer#getClosestYPosition tests 
The tests were removed in Iae0a78d0b8a13353de70794b67387f2c3bab44c6.
The ultimate goal is to refactor the renderer code and make it
testable, but before doing so we need to add tests to cover the existing
code. This will give us confidence that we won’t accidentally break
anything when we refactor.

Bug: T133022
Change-Id: I897276a1a953f6be62e4c2d4a24e0f22fc6ef141
 2017-05-01 10:56:41 -04:00