7 commits

Author	SHA1	Message	Date
Stephen Niedzielski	0bee0906d4	Hygiene: replace var with let and const ... eslint \ --cache \ --max-warnings 0 \ --report-unused-disable-directives \ --fix \ src tests Change-Id: I051275126ae7fa9affd16c2504017c0584f2d9c7	2018-03-20 14:14:02 -05:00
Stephen Niedzielski	ece4670710	Hygiene: use arrow for anonymous functions ... In some places, the arrow function seems more natural. This patch approximates the following with manual amendments: find \ -not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \ -iname \*.js| xargs -rd\\n sed -ri 's%function\s*(\([^)]*\))%\1 =>%g' Files to focus on were identified with: rg -slg\!/resources/dist/ -g\!/i18n/ -g\!/doc/ 'this|self|arguments|bind|call|apply|new'| xargs -rd\\n git difftool -y Bug: T165036 Change-Id: Ic66b6000b8fc000f9bfde39749f9cfa69924a13c	2018-03-20 09:27:08 -05:00
Jan Drewniak	f4d04b95b6	Updating mw-node-qunit to v3 ... Fixes tests for sinon v4, which is a dependency of mw-node-qunit v3. Bug: T180255 Change-Id: I8c7b703f81140e06546aa954f98b8766f5225ff5	2018-02-08 12:20:52 +01:00
joakin	4d8364a999	Hygiene: Use promises A/A+ everywhere ... Remove usages of deprecated methods like .done which make jquery promises fall back to non-standard behavior Additional changes: * Rename var promise to a more descriptive name in tests Bug: T173819 Change-Id: I7b041d0a7a8c42a8eac947295d265e898085c60a	2017-08-22 13:36:00 +02:00
jdlrobson	08331ba199	Return promises from QUnit test ... Simplify all our tests to return to promises Use catch rather than fail when testing error cases. Bug: T170812 Change-Id: I37c4e3f86343052c946d8586f8ff840a81f631f8	2017-08-17 14:34:39 +00:00
joakin	e6081106f1	Use EcmaScript modules instead of common.js modules ... Why: Because they are the approved standard by TC39 and Ecma for JavaScript modules. Changes: * Wrap mw-node-qunit in run.js to register babel to transpile modules for node v6 * Change all sources in src/ to use ES modules * Change constants.js to be able to run without jQuery.bracketedDevicePixelRatio given ES modules are hoisted to the top by spec so we can't patch globals before importing it * Change all tests in tests/node-qunit/ to use ES modules * Drop usage of mock-require given ES modules are easy to stub with sinon Additional changes: * Rename tests/node-qunit/renderer.js to renderer.test.js to follow the convention of all the other files * Make npm run test:node run only .test.js test files so that it doesn't run the stubs.js or run.js file. Bug: T171951 Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941	2017-07-31 23:05:44 +00:00
joakin	30550e2670	Test: Migrate wait.test.js to node-qunit ... Don't use fake timers for now because of some problems with other async tests. Change-Id: If48a8c7390416938d50c9c0c39539fe4a6a9a6af	2017-02-22 12:13:37 +01:00