wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-12-01 02:36:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
478 commits 12 branches 16 tags 68 MiB
Commit graph

17 commits

Author SHA1 Message Date
Prateek Saxena 93ef48221e Check renderers' matcher method to find the appropriate renderers for a link 
Right now the main renderer always picks the article renderer, no matter
if any other renderers is registered. It will now run the 'matcher'
method in the rendered, and if it returns true, we use that renderer.

Not sure how we'll avoid matchers stepping on each other.

Bug: T69434
Bug: T102921
Change-Id: Ib06812836cdbd3a5bfd54d4bc6147012fb891694
 2015-10-01 10:56:15 +02:00
jenkins-bot 486e34fb38 Merge "Move the article renderer in to the renderers property" 2015-10-01 08:50:39 +00:00
Prateek Saxena 1565a1d3c9 Move the article renderer in to the renderers property 
To allow multiple renderers (for different types of content)
to be defined.

Change-Id: I50320646e26f36a0a2bc425c82ccc58912840f84
 2015-10-01 08:48:00 +00:00
Prateek Saxena 6eef4f325b Add jscs and jshint tasks to the Gruntfile 
Adds the jscs and jshint packages for development and their tasks in
Grunt. Also fixes all the code convention errors.

Change-Id: If1c9dfdbe22d4912d78b6a51b1292866970a85cc
 2015-09-04 13:57:52 +05:30
jenkins-bot 0ff656a892 Merge "Implement the new schema for when the popups are enabled" 2015-04-06 09:18:16 +00:00
jenkins-bot d478a820a9 Merge "Rename popups.eventLogging to popups.logger" 2015-03-27 13:18:32 +00:00
se4598 946b4f4926 Do API queries after API_DELAY 
Based on the comments this is what it supposed to be.
mw.popups.render.article does the API-queries on init, so do that after
the API_DELAY-timer fired.

Change-Id: Ia235cbe1eb86fc774edda84208d320843401624e
 2015-03-26 15:03:38 +01:00
Prateek Saxena 2971d90831 Implement the new schema for when the popups are enabled 
Bug: T88167
Change-Id: I38c9e474e0ec7da45af8338a458430e5d7427463
 2015-03-26 11:42:39 +05:30
Prateek Saxena d49cfb9b65 Rename popups.eventLogging to popups.logger 
...and eventLogging.logEvent to logger.log

Change-Id: I9af697a56c2248069a32ac586f5b78b55095460e
 2015-03-26 04:56:29 +05:30
Prateek Saxena 44c57834b1 Disable Navigation Popups on render rather than document load 
Bug: T64952
Change-Id: I7985341006d587671077f3dc32dd02e8dfb38972
 2015-02-20 11:54:17 +01:00
Prateek Saxena 9c1c62ce05 Fix event logging issues 
- Don't prevent the link click event.
- Check with the currentLink element rather than jQuery selectoin.
- Add click handler to images (used to be only extract).
- Stop the 'closePopup' if 'reset' has already been run.

Bug: T86378
Change-Id: I8748ecffe55954425656c5103fa9ddc99b6f3f72
 2015-01-13 18:48:02 +05:30
Prateek Saxena 0630ff518c renderer: Actually use eventLogging 
This was accidentally removed during the refactor
and went unnoticed for quite some time.

Change-Id: I850126461b503419d1e219398f3d61747fbccb23
 2014-09-09 10:31:51 +05:30
Bartosz Dziewoński 3041d358ed Raise popup show/hide delay to 500ms/300ms, respectively 
Per discussion on the bug, the current values of 150ms/100ms cause a
lot of unintended actions.

Bug: 64234
Change-Id: I6fe2d89ad97630ec5c7f47d3e3b9b71d7cfc5d3f
 2014-06-20 16:48:00 +02:00
Prateek Saxena d1ddb95067 Flip the animation direction if the Hovercard is flipped 
Change-Id: I890d49c517a52e57e0b22bcf1949b347d531d6b7
 2014-05-30 16:25:14 +05:30
Prateek Saxena dd309071d2 animation: Correctly name the animation classes 
fade-in to fade-in-up
fade-out to fade-out-down

Change-Id: I6e8877a509fdb3e3f570e16d59438bff61e2615a
 2014-05-29 00:35:25 +00:00
Prateek Saxena 9cc318c3eb renderer: Ignore # links 
Bug: 65425
Change-Id: Ic610ee485da668b9a141234f56477faf7bcaa447
 2014-05-27 19:24:28 +05:30
Prateek Saxena e6f8834841 Restructuring code 
Bug: 61267
Change-Id: Ie4252c691abb7e6b2637d88b1adea5ce8871497c
 2014-04-30 16:48:05 +05:30