Previously, the name was "Page Previews". This is not true any more.
Reference as well as Math previews are developed. We changed the name
to "Previews".
This creates confusion because Special:Version does not contain the
word "popup" any more. I think it's worth fixing this.
Bug: T219153
Depends-On: Ie0060125cf4646d80f8c88eedd01551f66e3fb89
Change-Id: Id9862f45690f1c8b391f55d7fcaf88aa15f65912
doc.wikimedia.org is a helpful resource when iterating on a codebase.
Like MobileFrontend, generate documentation with Doxygen so that it can
be published there.
Note well that:
- The CALL_GRAPH and CALLER_GRAPH statements have been removed as they
were being set to the default value (NO)
- DOT_FONTSIZE was increased from 10 to 12
Bug: T242779
Change-Id: I41e4c6ca2b604382b036606ebcb40f11a1e8abc0
Appending --fix is what the eslint output suggests when
fixable errors are detectable, so better to just support
that than invent a new grunt sub-task.
Pass the same option to stylelint.
Change-Id: Ic8902f821d53a3fe6ca521ff1785c52baa99ceb1
Popups is enabled on the Wikipedias but disabled by default, which makes
it more difficult to enable on third-party wikis.
Things should be enabled by default, and them WMF configs should disable
features when they are not used/available.
Supporting changes:
- Rename PopupsContextTest#testAnonUserHasDisabledPagePreviews and
remove the associated data provider, which provided only one datum
- Set $wgPopupsReferencePreviews to false in
PopupsContextTest#testShouldSendModuleToUser in order to isolate the
code under test
Change-Id: Ib8cc7041d792bed0a19d18e14506627099a69bef
Move /docs/ui/README.md into /README.md. This fixes an issue where the
precommit script dirties the working directory on every commit (it
deletes docs/ui/README.md, which can be confusing) and makes the root
readme the single source of documentation.
Change-Id: Id99ca09b738a6fd3299f1acb4f238902461cdd95
Remove pluralization from the service wiring filename for consistency
with similar files in other Web repos. There are multiple services in
this file but the point of distinction doesn't seem worthwhile.
Change-Id: I6ff4f9caf66a6156f6aa6a8b808f51c356df3414
This is a direct follow up for I4d31805. Note the previous patch was
only testing the code path when Beta is disabled. But the bug was about
what happens when Beta is enabled. This is now properly covered by
these tests.
Bug: T240947
Change-Id: I54c5e9751e14a94808e85d935e1972eea0395002
It appears like we accidentially copy-pasted the behavior for
PagePreviews and made ReferencePreviews behave the same, not taking
into account that the later feature is in Beta mode.
Bug: T240947
Change-Id: I4d31805ee9b2045c49c7ab4179c5a4adbcba0394
It is possible, but very rare to have more than a single hook handler
per hook in a single extension. The value can be an array or string in
both version 1 and 2 of extension.json.
Change-Id: If3a7d89030b28b46e3601c63cda2b3fed14eb00c
