wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-30 10:25:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
2869 commits 12 branches 16 tags 68 MiB
Commit graph

2869 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jon Robson 58156d2aa7 Scope rule to Popups 
This rule is clashing with some special behaviour in Minerva
relating to labels being shown to desktop users

Follow up to I86972322ae34f1d1df8d79c66daa9e34091f9dd3

Bug: T319260
Bug: T340262
Change-Id: If6f8ee2793726306675a7e6c7de0495065644394
 2023-07-27 12:13:41 -05:00
Translation updater bot 970e7112a5 Localisation updates from https://translatewiki.net. 
Change-Id: I935ec80d45477b42506a17f37eb384eeef2d1934
 2023-07-24 09:39:21 +02:00
jenkins-bot 5edfaad0f0 Merge "Don't log for documentElement (nodeType 9)" 2023-07-18 21:37:44 +00:00
Jon Robson 5af31b5524 Don't log for documentElement (nodeType 9) 
Follow up to Ia011aaf9f8b5b932695da3311f849682c0105cfe

Bug: T340081
Change-Id: Ibff26eb90fd650532a7e23ac16232366676c0d15
 2023-07-18 20:34:47 +00:00
jenkins-bot 6b153fcc44 Merge "Add additional debugging closest bug" 2023-07-18 14:47:10 +00:00
WMDE-Fisch c2413c858b selenium: Refactor WebdriverIO tests from sync to async mode 
I also removed the bool on the shouldUseReferencePopupsBetaFeature
method. It was always just used with `true`

Bug: T293072
Change-Id: I1a2d6f912fcac2ac77539581897e0feab489edf0
 2023-07-18 09:34:47 +02:00
Jon Robson a80d2b1f56 Add additional debugging closest bug 
Use the topic "error.web-team" - error prefix necessary
for it to be treated as an error, and 'web-team' moves
it off main channel.

Error logs tagName and nodeType which should be sufficient
for us to understand this issue. Can expand with other
information later if need be. Cannot add to stack trace
as any non-standard stack trace would be dropped by the intake
code.

Bug: T340081
Change-Id: Ia011aaf9f8b5b932695da3311f849682c0105cfe
 2023-07-17 14:54:12 -07:00
Translation updater bot 6ee797e897 Localisation updates from https://translatewiki.net. 
Change-Id: Ic46bf1de6d9ef6d373c33b50d76609765d347a50
 2023-07-17 10:18:29 +02:00
Jon Robson 36101004e7 Browser tests: Skip another test 
Bug: T341763
Change-Id: I37d8c62c1e10160bc27ed9135fd3765cccf77be5
 2023-07-14 09:57:28 -07:00
Jon Robson 3d627fe731 Skip flakey Selenium test for now 
This test is failing regularly on the daily build. I manually
checked and could see no problems with the functionality:
https://integration.wikimedia.org/ci/job/selenium-daily-beta-Popups/

Bug: T341763
Change-Id: Id3a3a1c16c400796467496d8934fdff7a14be9fb
 2023-07-13 15:15:34 +00:00
bwang 6b659443b5 Update popups to use codex buttons over mediawiki.ui.buttons 
- Provides missing accessible label for the settings button

Bug: T340256
Change-Id: I86972322ae34f1d1df8d79c66daa9e34091f9dd3
 2023-07-10 16:03:36 -05:00
Moh'd Khier Abualruz 67a718a5be TypeError: n.closest is not a function 
- check if the element has the function in it before using it
- implementing a native code to get the same result based on polyfill examples
- fix Coverage Block

Bug: T340081
Change-Id: I1c2ce46a88cde6323ab862964062dd722ff5edcb
 2023-07-10 11:48:40 -07:00
jenkins-bot b54ba6d10a Merge "When extract is a string treat it as HTML" 2023-07-10 18:40:04 +00:00
Translation updater bot 36308439b3 Localisation updates from https://translatewiki.net. 
Change-Id: I59f5bb86e3dd34d20350c41328994cad888ceb11
 2023-07-10 09:38:46 +02:00
Jon Robson 9ee816a919 When extract is a string treat it as HTML 
According to the docs:
The Element.append() method inserts a set of Node objects or string
objects after the last child of the Element.
String objects are inserted as equivalent Text nodes.

When given a string we want to treat these as HTML

Also fix the storybook which hinted at this being a problem
(incorrectly fixed in 504eefcc1)

Bug: T341318
Change-Id: I415c9821a6a37b45cf0f8a65f58a41bc7d0a042d
 2023-07-07 10:09:28 -07:00
jenkins-bot efd0a0c91e Merge "Fix storybook stories" 2023-07-03 14:00:05 +00:00
Translation updater bot 6a12bd85fc Localisation updates from https://translatewiki.net. 
Change-Id: I5027df69f8cd3fe691602f7dd3438ee8eb9fd435
 2023-07-03 10:16:04 +02:00
Jon Robson 504eefcc18 Fix storybook stories 
This was broken when we switched from jQuery to native JavaScript

Change-Id: I318a51a7d8836370f795b1008b8a89b6ca0edb35
 2023-06-30 09:41:53 -07:00
WMDE-Fisch 606475f80e selenium: run tests concurrently 
Includes a bit untangling of the reference and page previews tests
and simplifies the setup.

Bug: T337862
Change-Id: Ia92cccb90fd79d10c5b33744520cb963a65db046
 2023-06-30 08:52:47 +02:00
WMDE-Fisch e44c406ba2 Import theme-wikimedia-ui.less for storybook build 
Not sure when this should have been added but the test were
failing because of this missing ressource.

Change-Id: I0267aae18d0f33ac3d607fb0b6013f108f2e5d83
 2023-06-30 08:22:47 +02:00
Translation updater bot e8001c0c1a Localisation updates from https://translatewiki.net. 
Change-Id: Ie9626aee24a078b648d78b77137e9846e79e9ac7
 2023-06-26 12:40:35 +02:00
Translation updater bot 28481af224 Localisation updates from https://translatewiki.net. 
Change-Id: I73c72d93173d0319809bc40d5a7f420f11739593
 2023-06-19 11:07:48 +02:00
jenkins-bot 655f08aa8a Merge "Publish coverage file" 2023-06-15 16:38:24 +00:00
Jon Robson bf63e2bc6e Publish coverage file 
Context [[mw:Topic:Xk10fxsoqth6scfz]]

Change-Id: Ic99cf9bdffdeb56a6182e650d3878902696c0df0
 2023-06-15 08:53:39 -07:00
Volker E 4132ee96ab build: Update SVGO to v3.0.2 
svgo         2.8.0  →   3.0.2

Amending to new `cleanupIds` plugin name.

Bug: T339162
Change-Id: I8ad37e46501c36883967827b4d622788ae9065f1
 2023-06-14 12:32:01 -07:00
Jon Robson 049729626c IP masked users use localStorage for settings 
Bug: T330517
Change-Id: Ib283e37f379e8cccc7f49ab0ce9aadd6535ea668
 2023-06-14 08:16:50 -07:00
jenkins-bot 140c9bf1ab Merge "Discourage jQuery usage in Popups extension" 2023-06-14 14:24:10 +00:00
Translation updater bot 2f38a45e83 Localisation updates from https://translatewiki.net. 
Change-Id: I8d300a9bc7979a07e29f1ec57622a32eeafb3715
 2023-06-14 13:07:45 +02:00
Jon Robson 580067b94e Discourage jQuery usage in Popups extension 
Change-Id: Iff0c81e4c1d78cc52d1bd9d81e24d8fae228c9bc
 2023-06-13 15:39:57 -07:00
jenkins-bot e8204a5aca Merge "Prevent Enabling Beta Preferences for temp users" 2023-06-12 19:10:02 +00:00
Translation updater bot ca52ea132f Localisation updates from https://translatewiki.net. 
Change-Id: I3d0fd448fa69bdb762e4eec17757e53e547a1377
 2023-06-12 13:08:00 +02:00
Translation updater bot 19080f1cc3 Localisation updates from https://translatewiki.net. 
Change-Id: I19c6ddbf9b619e06cc8265d4fa78f7517fc09ce8
 2023-06-09 09:14:35 +02:00
AnaïsGueyte 1f5510bc2a Prevent Enabling Beta Preferences for temp users 
Bug: T337776
Change-Id: I3e7c9524a405d62796dca42abe3d04fa5025dc81
 2023-06-08 11:39:48 -02:30
Translation updater bot 808d8bcd6c Localisation updates from https://translatewiki.net. 
Change-Id: I88fd11e853895f128ae7a6618376982c1b454e95
 2023-06-06 08:11:40 +02:00
Translation updater bot bcd802659c Localisation updates from https://translatewiki.net. 
Change-Id: I8865384dfa1bce452e2671f01ba543643dd2bac9
 2023-06-02 09:24:38 +02:00
libraryupgrader faa3c63af8 build: Updating npm dependencies 
* grunt-banana-checker: 0.10.0 → 0.11.0
* stylelint-config-wikimedia: 0.14.0 → 0.15.0

Change-Id: Ie2be62f89f01533a83982880a0ea7a2a71405b37
 2023-06-02 01:01:00 +00:00
Translation updater bot 484c932ea7 Localisation updates from https://translatewiki.net. 
Change-Id: Idd681e0220beb624f60168ec2d1e4274dc6b3a5c
 2023-05-29 09:59:55 +02:00
jenkins-bot a38f4c5336 Merge "Prefer native JavaScript to jQuery" 2023-05-26 03:22:52 +00:00
libraryupgrader 32778684af build: Updating npm dependencies 
* @wikimedia/codex: 0.10.0 → 0.11.0
* @wikimedia/codex-icons: 0.10.0 → 0.11.0

Change-Id: Ic5218ad62e27900eb6a96461d9aa9126829f70e0
 2023-05-24 00:54:43 +00:00
Translation updater bot 523b76bdb4 Localisation updates from https://translatewiki.net. 
Change-Id: I8723840ed5f21cbb486745c289a6b6d018174dde
 2023-05-22 08:46:22 +02:00
Jon Robson 7c592bc790 Prefer native JavaScript to jQuery 
Bug: T315929
Change-Id: I949fd9551269a3cb9d9df7744149510949d3076c
 2023-05-21 16:53:50 +00:00
Umherirrender 9da6586158 tests: Make PHPUnit data providers static 
Initally used a new sniff with autofix (T333745)

Bug: T332865
Change-Id: I1a585a5e81ad0355b3be806da249e632f3fd21ec
 2023-05-20 13:56:14 +02:00
libraryupgrader 3840382ba1 build: Updating npm dependencies 
* @wikimedia/codex: 0.9.1 → 0.10.0
* @wikimedia/codex-icons: 0.9.1 → 0.10.0

Change-Id: I5e8d4af946ae8d679f9cedbe34eac9f221035bef
 2023-05-17 00:51:30 +00:00
Jon Robson 323d770d66 Use native JavaScript to build thumbnail clip path 
Change-Id: Ib5d734fde88eaa20ec866722af3de37abe694add
 2023-05-16 17:19:47 -07:00
Jon Robson 1ee66bbf72 Don't use parseHTML in parseHTMLResponse 
These changes impact the preview itself and the settings
dialog which shows to anonymous users

Change-Id: If288161fb5eb4446a79e68841ab53a6c713f1d3a
 2023-05-16 17:18:06 -07:00
Umherirrender 7a6cac8a64 build: Updating eslint-config-wikimedia to 0.25.0 
Change-Id: Ic511f54b58947a2694514e2d417e022bdeae219d
 2023-05-16 00:22:03 +02:00
Jon Robson 875f7ffcad Use native JavaScript for creating the footer link 
The footer link shows when a page preview has been disabled
by an anonymous user via the settings cog.

Change-Id: I236a620322716f42443fc3d90a0405352132a99f
 2023-05-15 14:19:41 -07:00
Jon Robson 3bd4275023 Fix test case with type with space in it 
Types should not have spaces in them. In the current example this
results in a page preview element with an additional class "<"\'>"
I'm not sure what this is protecting against since we can trust types
to always be in a sensible class friendly form. It would be better
to throw an error in the mw.popups.register function than allow this.

Change-Id: If08c5162c1ca0fc3db4944092231061e22113263
 2023-05-15 14:18:39 -07:00
Jon Robson 76973662d1 Fixes: Uncaught TypeError: n.closest is not a function 
Previously we did a try/catch when closest didn't exist. Now that's
gone we're flagging this issue.

Follow up to Ia45c03d1fd6949bf83ebed6d40075e453e42cdd7

Bug: T336650
Change-Id: I7a4f453ae1a4a8222863a8342a27d615883d339a
 2023-05-15 07:27:22 -07:00
Translation updater bot de881b7e6e Localisation updates from https://translatewiki.net. 
Change-Id: Icb38c173922d97885351246571a93b7381576caf
 2023-05-15 08:33:35 +02:00