wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-12-23 12:33:00 +00:00
Code Issues Packages Projects Releases Wiki Activity
2803 commits 14 branches 16 tags 72 MiB
Commit graph

2803 commits

This branch
This branch
All branches
Author SHA1 Message Date
Shreyas Minocha 22226f3367
Switch from babel-preset-env to @babel/preset-env 
Replace:
    - babel-preset-env@1.6.0 with @babel/preset-env@7.2.0
    - babel-register@6.24.1 with @babel/register@7.0.0
    - babel-loader@7.1.4 with babel-loader@8.0.4

Add:
    - @babel/core@7.2.0

---

- babel-preset-env, @babel/preset-env
  babel-preset-env moved to @babel/preset-env in the Babel monorepo.
  This appears to have incremented the version from v1.6.0[0] to 7.x to
  match the rest of the Babel packages but appears to otherwise be
  undocumented.[1,3]

  [0] https://github.com/babel/babel-preset-env/blob/24b99ec/README.md
  [1] https://github.com/babel/babel/blob/efa571a/CHANGELOG.md

- @babel/preset-env, @babel/register
  *Many* changes as identified by package [2] and summarized [3].

  Node.js v6 or above now required.

  New dependency on @babel/core.

  Support for ES2018 and browserslist v4.

  `modules: false` is now the default for preset-env + babel-loader. The
  .babelrc has been updated.

  New babel-upgrade tool.

  babel.config.js can replace .babelrc. Popups doesn't seem to need it.

  TypeScript and JSX fragment support.

  [2] https://github.com/babel/babel/blob/efa571a/CHANGELOG.md
  [3] https://babeljs.io/blog/2018/08/27/7.0.0

- babel-loader
  Support for Babel 7.x.

  The following warning is printed when building but perhaps this is due
  to another dependency:

    (node:14559) DeprecationWarning: loaderUtils.parseQuery() received a
    non-string value which can be problematic, see
    https://github.com/webpack/loader-utils/issues/56 parseQuery() will
    be replaced with getOptions() in the next major version of
    loader-utils.

  https://github.com/webpack/loader-utils/issues/56#issuecomment-286117000
  https://github.com/babel/babel-loader/releases/tag/v7.1.5
  https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.0
  https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.1
  https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.2
  https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.3
  https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.4
  (v8.0.0-beta.5 was erroneous.)
  https://github.com/babel/babel-loader/releases/tag/v8.0.0-beta.6
  https://github.com/babel/babel-loader/releases/tag/v8.0.0
  https://github.com/babel/babel-loader/releases/tag/v8.0.1
  https://github.com/babel/babel-loader/releases/tag/v8.0.2
  https://github.com/babel/babel-loader/releases/tag/v8.0.3
  https://github.com/babel/babel-loader/releases/tag/v8.0.4

Bug: T197883
Change-Id: Ie3a5404630fde87ea7fe618a842950ed8c0c6494
 2018-12-11 13:09:45 +05:30
jenkins-bot 301df2cdea Merge "Hygiene: remove package-lock.json" 2018-12-10 23:55:09 +00:00
jenkins-bot b7b46b5fae Merge "Fix bug in ABANDON_END test" 2018-12-10 16:09:50 +00:00
Umherirrender 033cf7a795 build: Update sniff list in .phpcs.xml 
FunctionDeclarationArgumentSpacing is now part of the default

Change-Id: I6e6638e1e115dd793b58cc18852aaaa5d282846c
 2018-12-08 15:34:57 +01:00
Shreyas Minocha 9e515f73e7
Fix bug in ABANDON_END test 
Change-Id: Ic0b6404630fde88ea7fe571a842950ec8c0c648f
 2018-12-08 11:17:34 +05:30
Stephen Niedzielski 6d4eebe12b Hygiene: remove package-lock.json 
Remove package-lock.json until a Node.js version that supports it is
possible.

Change-Id: I00d2168d8671d0f7fa2b999171e03c13bfac192a
 2018-12-03 09:32:52 -07:00
Translation updater bot 53015b7237 Localisation updates from https://translatewiki.net. 
Change-Id: Ib0b6404630fde88ea7fe618a842950ec8c0c648e
 2018-12-02 22:15:04 +01:00
Translation updater bot 7953a2709d Localisation updates from https://translatewiki.net. 
Change-Id: I0c528b44c87e727fa0cae9775029dd6df12964be
 2018-11-25 22:34:11 +01:00
Translation updater bot 6c22f0d96b Localisation updates from https://translatewiki.net. 
Change-Id: I5014349e5581a5e4b85f3ab896f84630e6dfc516
 2018-11-21 22:29:20 +01:00
Translation updater bot f3751463fc Localisation updates from https://translatewiki.net. 
Change-Id: Ic6c98be126addf0481a05e02c76f7f5d01a0c584
 2018-11-17 22:19:51 +01:00
Stephen Niedzielski a24bbe76e6 Hygiene: use source-maps for dev builds not eval maps 
Webpack's `-d` option is an alias for
`--debug --devtool cheap-module-eval-source-map --output-pathinfo`[0]
which overrode the `devtool` specified in the config. Specify
`--mode=development` which appears to be better supported than `-d`,
although the distinction is poorly documented[1]. The build products are
identical for `--mode=development --debug --output-pathinfo` and simply
`--mode=development` so the latter is used.

For consistency, replace `-p`, an alias for
`--optimize-minimize --define process.env.NODE_ENV=production`[0],
where `--optimize-minimize` is documented[2] as:

  Minimize JavaScript and switches loaders to minimizing UglifyJsPlugin
  and LoaderOptionsPlugin.

With `--mode=production` which is documented[3] as:

  Sets process.env.NODE_ENV on DefinePlugin to value production. Enables
  FlagDependencyUsagePlugin, FlagIncludedChunksPlugin,
  ModuleConcatenationPlugin, NoEmitOnErrorsPlugin,
  OccurrenceOrderPlugin, SideEffectsFlagPlugin and UglifyJsPlugin.

This change has already been made to MobileFrontend in c10f87d89.

[0] https://webpack.js.org/api/cli/#shortcuts
[1] https://medium.com/webpack/webpack-4-released-today-6cdb994702d4#dfa8
[2] https://webpack.js.org/api/cli/#optimize-options
[3] https://webpack.js.org/concepts/mode/#usage

Change-Id: I7a7ffc913592f0b18e091bb219a7fc75873d4d7a
 2018-11-16 13:17:46 -07:00
libraryupgrader 750a357434 build: Updating mediawiki/mediawiki-codesniffer to 23.0.0 
Change-Id: I046509fb8fa8c7e3e3ad8ab00062212498da54d0
 2018-11-16 07:41:01 +00:00
Translation updater bot b7f0a9e0c7 Localisation updates from https://translatewiki.net. 
Change-Id: Ie7eb4531cffee9534136779d5b64b8cd1eefb18d
 2018-11-12 22:12:54 +01:00
Translation updater bot fa8af07513 Localisation updates from https://translatewiki.net. 
Change-Id: I76384f034e05632b3f74602ada589e23a61c222d
 2018-11-04 22:42:33 +01:00
Translation updater bot 605b13ff97 Localisation updates from https://translatewiki.net. 
Change-Id: Icc70b5dd3afbdf0bc36e7c3f778392f4350ea9d0
 2018-10-18 22:34:27 +02:00
Stephen Niedzielski 4d44390a4b Hygiene: enable ESLint caching 
Copy ESLint caching configuration from MinervaNeue.

eead7c9382%5E%21/

Change-Id: Ifee0f67392f73c1285da7767a949998520bf4a0d
 2018-10-17 16:45:35 -06:00
Stephen Niedzielski c7e742743b Doc: fix fetch delay comments 
FETCH_COMPLETE_TARGET_DELAY is used to introduce an artificial delay to
HTTP requests as needed. However, FETCH_START_DELAY is always accounted
for so it makes sense to define FETCH_COMPLETE_TARGET_DELAY with it. The
docs are updated to draw the distinction between total delay and API
response delay.

Change-Id: I4cddc89b8090d54db0dd85f270441cab17c54993
 2018-10-17 16:44:16 -06:00
jenkins-bot 471ea931de Merge "Hygiene: limit ESLint inheritance" 2018-10-17 22:37:08 +00:00
jenkins-bot 1db76db5ae Merge "Doc: fix type in getPageviewTracker()" 2018-10-17 22:31:05 +00:00
Translation updater bot b76034988d Localisation updates from https://translatewiki.net. 
Change-Id: Ibf11cf0b65e97af4c42f624953ac3423cd0819de
 2018-10-17 23:44:29 +02:00
Stephen Niedzielski d1ef4cbe88 Hygiene: limit ESLint inheritance 
The project ESLint configuration unintentionally inherited unwanted
configuration from MediaWiki, which allows global jQuery usage. Cap the
project's ESLint hierarchy at the project root.

Change-Id: I5177d306feface7fcce0867c624bbcf9e74f19fc
 2018-10-16 16:22:25 +00:00
Translation updater bot 87112444c4 Localisation updates from https://translatewiki.net. 
Change-Id: I2b92645b27b057a266daf70b97ece8dd37aa3c52
 2018-10-11 22:37:27 +02:00
Translation updater bot 1bc072f9bd Localisation updates from https://translatewiki.net. 
Change-Id: If85e6f6b48f468c2d7da69ef5576a9b538152417
 2018-10-09 22:13:03 +02:00
Translation updater bot 1e352ce7de Localisation updates from https://translatewiki.net. 
Change-Id: If6885d4317d692305729b81bad2c633c3b59cf0d
 2018-10-06 22:35:36 +02:00
James D. Forrester 505ddc61fa PHP tests: Use the . not + operator to join strings 
This unbreaks the test suite in PHP 7.1+.

Bug: T206297
Change-Id: I29677e84f41da447180beb58ffbc60655640890c
 2018-10-05 15:47:05 -07:00
Stephen Niedzielski 6e3f90016a Doc: fix type in getPageviewTracker() 
Change-Id: I45b9456e0869657069c4a961171fd89415bf5656
 2018-10-05 10:41:23 -06:00
Translation updater bot 1c3b5307e7 Localisation updates from https://translatewiki.net. 
Change-Id: Ic9810142f096b906047bd3a0e6ecb15c942cec79
 2018-10-04 22:24:22 +02:00
Translation updater bot 23425e3acd Localisation updates from https://translatewiki.net. 
Change-Id: I0d2043940d7e1cf68aaaa5be689f855b0ab022f1
 2018-10-03 18:53:40 +02:00
Translation updater bot 49878e43d5 Localisation updates from https://translatewiki.net. 
Change-Id: I16c662e1552abc74af1648cda35c9f951c5b345d
 2018-09-26 13:46:13 +02:00
Volker E 3cfb1d346a Amend preferences message to unify with messages elsewhere 
The other messages when announcing a widget below use a ':' at the
end of line and add extra information in brackets, not on a new line.

Bug: T203992
Change-Id: Ide151e39159df01fa1c97c808bcf7ad29c671580
 2018-09-24 16:50:03 -07:00
Translation updater bot a449690dc9 Localisation updates from https://translatewiki.net. 
Change-Id: I0b29750b8ff5e3d782a624f044e2a0614ba4a84c
 2018-09-23 10:27:15 +02:00
Translation updater bot 4e944dd48a Localisation updates from https://translatewiki.net. 
Change-Id: I38cd3f2a08316535e0bef7d668454e13f7131d5d
 2018-09-22 10:03:50 +02:00
Fomafix 5b6fe60407 Do not use jQuery's hasClass with space separated classes 
A parameter with space separated class names is not specified in
https://api.jquery.com/hasClass/

Change-Id: I1b44215115a3e51319c042f0f20547cff640ab52
 2018-09-21 08:20:12 -06:00
Translation updater bot f0d59dfcc1 Localisation updates from https://translatewiki.net. 
Change-Id: I4d566c9607214a7f87528eca7da613b83c49f0f8
 2018-09-21 10:35:20 +02:00
jenkins-bot e4af99f94f Merge "Simplify JavaScript by using native ES5 instead of jQuery" 2018-09-18 17:24:15 +00:00
Fomafix ae472fe689 Simplify JavaScript by using native ES5 instead of jQuery 
jQuery.isFunction is deprecated since jQuery 3.3.
https://blog.jquery.com/2018/01/19/jquery-3-3-0-a-fragrant-bouquet-of-deprecations-and-is-that-a-new-feature/
A simple thruthy check suffices here.

Also make the parameters of isValid mandatory.

Change-Id: Ief595dd3304016011cf6df1ffbe88cd51d4ec9ea
 2018-09-18 10:08:34 -07:00
Translation updater bot 64f4980a27 Localisation updates from https://translatewiki.net. 
Change-Id: I22812458182af0210fb47621e7fe80af54b155b2
 2018-09-18 09:52:25 +02:00
Translation updater bot 18d8561a8d Localisation updates from https://translatewiki.net. 
Change-Id: I596e6e20f1dc2053d9e8f8b8522222bc4491328a
 2018-09-17 10:18:25 +02:00
Translation updater bot 812148fda9 Localisation updates from https://translatewiki.net. 
Change-Id: I86eecb9c95110f2589cd8eb6d7b025f6ad1255c9
 2018-09-15 09:54:32 +02:00
Translation updater bot e19e209f08 Localisation updates from https://translatewiki.net. 
Change-Id: Ie3e5545f14ecbef39052935eb857adca9b979286
 2018-09-13 10:15:57 +02:00
Volker E 567bd4176f Remove unique and misplaced italicized text from preferences setting 
This is the first step, in a second after the OOUI rollout we should also
remove the paragraphs within the `label`, for appearance and HTML validation
reasons.

Bug: T203992
Change-Id: I4a12e4572ae2518079616e3765a5d3954aab794b
 2018-09-12 15:44:10 -07:00
Translation updater bot 7c616db10b Localisation updates from https://translatewiki.net. 
Change-Id: I7cc40e695817d96c3a31043fce7dc8d20aa6b82e
 2018-09-12 09:19:08 +02:00
Ed Sanders c74d2e5313 build: Update linters 
Bug: T202739
Change-Id: Ie3f68977598f46f7e12b216f8381b2e9dc6d83ad
 2018-09-11 10:26:35 -07:00
libraryupgrader 5635d8863b build: Updating mediawiki/phan-taint-check-plugin to 1.5.0 
Change-Id: Ia9c9cc3426d811d2b7341323f58d73479d5e9943
 2018-09-08 04:56:41 +00:00
Translation updater bot 75139cf1df Localisation updates from https://translatewiki.net. 
Change-Id: I6abcc9f17409dfc9ec29e5c91646b5e2fe1580f6
 2018-09-07 09:03:00 +02:00
Antoine Musso 99d0092096 QA: add missing wdio-junit-reporter 
tests/selenium/wdio.conf.js defines a Junit reporter but it is not
installed when running the suite directly from the extension.

Bug: T203591
Change-Id: Idf192506d0af01abbfea479223a3bbcfc5eef4ea
 2018-09-06 16:08:44 +02:00
jenkins-bot ddc705c664 Merge "Selenium: add selenium-daily NPM script" 2018-09-06 08:20:04 +00:00
Stephen Niedzielski 16004549cf Doc: add linkInteractionToken description 
Add documentation for the Schema:Popups' linkInteractionToken property
in the EventLogging reducer.

https://meta.wikimedia.org/wiki/Schema:Popups

Bug: T203013
Change-Id: I7fc872beda284ef8639ad036ddeb9efc8581a452
 2018-09-05 20:02:32 +00:00
jdlrobson 53d1a2c329 Use getPageviewToken api 
Currently the Popups schema is disabled but if we were to re-enable
it, the page tokens would now be consistent with the ReadingDepth
schema

The getToken function is kept to allow generation of the
pageInteractionToken's relating to a link interaction, for which
there is no centralised API.

Additional changes:
* I've updated various tests to use the central mw.user stub to make
clearer where tokens come from.

Bug: T203013
Change-Id: If746bea5aeed2b4c192a9b8a02feb1fe06480633
 2018-09-05 20:02:17 +00:00
jenkins-bot 14df0a587c Merge "Update package.json to ensure assets get built on every commit" 2018-09-05 19:50:42 +00:00