Stephen Niedzielski
|
007cc5ab7c
|
Hygiene: favor string templates over concatenation
Update the ESLint config to favor ES6 strings where variables or string
concatenation is used and fix *all* offenders automatically via:
eslint \
--cache \
--max-warnings 0 \
--report-unused-disable-directives \
--fix \
src tests
Change-Id: I1a9345162348e5ded21d541e7a2ce251ea72ab5a
|
2018-03-21 08:05:55 -05:00 |
|
|
Stephen Niedzielski
|
57762e0417
|
Hygiene: favor const
Bug: T165036
Change-Id: I17d374eaac6627ca6a8ba178862b2a9cff2538c0
|
2018-03-21 10:44:24 +00:00 |
|
|
Stephen Niedzielski
|
0bee0906d4
|
Hygiene: replace var with let and const
eslint \
--cache \
--max-warnings 0 \
--report-unused-disable-directives \
--fix \
src tests
Change-Id: I051275126ae7fa9affd16c2504017c0584f2d9c7
|
2018-03-20 14:14:02 -05:00 |
|
|
Stephen Niedzielski
|
ece4670710
|
Hygiene: use arrow for anonymous functions
In some places, the arrow function seems more natural. This patch
approximates the following with manual amendments:
find \
-not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \
-iname \*.js|
xargs -rd\\n sed -ri 's%function\s*(\([^)]*\))%\1 =>%g'
Files to focus on were identified with:
rg -slg\!/resources/dist/ -g\!/i18n/ -g\!/doc/ 'this|self|arguments|bind|call|apply|new'|
xargs -rd\\n git difftool -y
Bug: T165036
Change-Id: Ic66b6000b8fc000f9bfde39749f9cfa69924a13c
|
2018-03-20 09:27:08 -05:00 |
|
|
Stephen Niedzielski
|
a67466acc0
|
Hygiene: replace obvious function methods
Replace easily identifiable object functions with method syntax:
find \
-not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \
-iname \*.js|
xargs -rd\\n sed -ri 's%:\s*function\s*(\([^)]*\))%\1%g'
Bug: T165036
Change-Id: I90693ee99a6a36dff820dd5ae6f6000429763058
|
2018-03-20 09:27:07 -05:00 |
|
|
Stephen Niedzielski
|
e26c12db52
|
Hygiene: move thumbnail code to separate file
Move thumbnail code from renderer to a separate file, thumbnail.
Bug: T165036
Change-Id: I6c55750ec302de6341e8e91dee34581ee66499d7
|
2018-03-14 14:19:41 -05:00 |
|