Stephen Niedzielski
|
ae44042cbf
|
Hygiene: add assertion messages
Change-Id: Ic0a47bd468532824e8648c3f6371cc403896603c
|
2018-05-08 15:55:23 -05:00 |
|
|
Stephen Niedzielski
|
57762e0417
|
Hygiene: favor const
Bug: T165036
Change-Id: I17d374eaac6627ca6a8ba178862b2a9cff2538c0
|
2018-03-21 10:44:24 +00:00 |
|
|
Stephen Niedzielski
|
0bee0906d4
|
Hygiene: replace var with let and const
eslint \
--cache \
--max-warnings 0 \
--report-unused-disable-directives \
--fix \
src tests
Change-Id: I051275126ae7fa9affd16c2504017c0584f2d9c7
|
2018-03-20 14:14:02 -05:00 |
|
|
Stephen Niedzielski
|
ece4670710
|
Hygiene: use arrow for anonymous functions
In some places, the arrow function seems more natural. This patch
approximates the following with manual amendments:
find \
-not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \
-iname \*.js|
xargs -rd\\n sed -ri 's%function\s*(\([^)]*\))%\1 =>%g'
Files to focus on were identified with:
rg -slg\!/resources/dist/ -g\!/i18n/ -g\!/doc/ 'this|self|arguments|bind|call|apply|new'|
xargs -rd\\n git difftool -y
Bug: T165036
Change-Id: Ic66b6000b8fc000f9bfde39749f9cfa69924a13c
|
2018-03-20 09:27:08 -05:00 |
|
|
jdlrobson
|
cf774be88b
|
Port Popups browser tests to selenium
Bug: T177262
Change-Id: Ie77cf7bc79f454904983ed5cf65dc9fe2b1ececc
|
2017-11-01 13:31:36 -07:00 |
|