5 commits

Author	SHA1	Message	Date
joakin	807100bcca	Limit line length to 80 characters ... Enforce it with eslint. Ignore: * Comment lines with eslint disable directives * QUnit test lines as they contain long subjects (QUnit.* (only, test, module, skip, etc) * Strings, since long strings are used extensively in tests * Ignore template literals for similar reasons * Regex literals as they may be too long, but can't be easily split in several lines * Long urls See bug for more general proposal for eslint-wikimedia-config. Bug: T185295 Change-Id: I3aacaf46e61a4d96547c513073e179ef997deb09	2018-01-19 14:20:39 +01:00
Ed Sanders	7f4dd1159b	build: Update eslint and other linters ... Change-Id: I0a20ad5d16d46afbc2a328f8e254295972f58ab0	2017-10-09 15:56:15 +01:00
joakin	e6081106f1	Use EcmaScript modules instead of common.js modules ... Why: Because they are the approved standard by TC39 and Ecma for JavaScript modules. Changes: * Wrap mw-node-qunit in run.js to register babel to transpile modules for node v6 * Change all sources in src/ to use ES modules * Change constants.js to be able to run without jQuery.bracketedDevicePixelRatio given ES modules are hoisted to the top by spec so we can't patch globals before importing it * Change all tests in tests/node-qunit/ to use ES modules * Drop usage of mock-require given ES modules are easy to stub with sinon Additional changes: * Rename tests/node-qunit/renderer.js to renderer.test.js to follow the convention of all the other files * Make npm run test:node run only .test.js test files so that it doesn't run the stubs.js or run.js file. Bug: T171951 Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941	2017-07-31 23:05:44 +00:00
joakin	356678ffcd	Add title#isValid ... Which checks if a title is an eligible one for showing previews Bug: T165572 Change-Id: I5ade3fb84d400293d24de05e10119996e711b41e	2017-06-08 12:29:33 -07:00
joakin	ef2f99ef65	Rename getTitle.js to title.js ... In order to create a title#shouldShowPreview function next in the module. Bug: T165572 Change-Id: I9e59bb0f525d2698f882543ca0d4a1bde6b2d5d2	2017-06-08 12:10:14 +02:00

Renamed from tests/node-qunit/getTitle.test.js (Browse further)