4 commits

Author	SHA1	Message	Date
Stephen Niedzielski	ae44042cbf	Hygiene: add assertion messages ... Change-Id: Ic0a47bd468532824e8648c3f6371cc403896603c	2018-05-08 15:55:23 -05:00
Stephen Niedzielski	cb362d125c	Hygiene: replace calledOnce / Twice w/ callCount ... Replace all test assertions for calledOnce / Twice with callCount. assert.ok( calledOnce / Twice ) only lets the dev know that a test fails. assert.strictEqual( callCount, EXPECTATION ) starts the debugging process when it fails since it provides the difference in the failure output. strictEqual() was deliberately used since it's a saner default and the codebase already favors === equivalency checks. find tests -name \*.js| xargs -rd\\n sed -ri ' s%ok\(([^,]+)calledOnce%strictEqual(\1callCount, 1%g; s%ok\(([^,]+)calledTwice%strictEqual(\1callCount, 2%g; ' Change-Id: I07c3c6d20e07c5b8107583a01d820e3fbd68a4e1	2018-05-08 15:01:16 -05:00
Piotr Miazga	321d6348e1	Page_title and source_title should be in canonical form ... We change page_title and source_title as a last step just before we send the event. Doing it elsewhere is risky at the current time because: * the non-canonical form is needed for mwApiGateway to bold title (formatPlainTextExtract). Needing both would require updates to the Page model. * title is used by EventLogging (Schema:Popups) Bug: T191471 Change-Id: I93e7343643dcd9f32a86459907eb0b7051df91aa	2018-04-16 19:56:43 +02:00
jdlrobson	e6202b6ce4	VirtualPageViews bypass EventLogging for logging virtual events ... We are using EventLogging to track page views not user behaviour. This is an exception to the rule and requires special handling. Bug: T190188 Change-Id: If096ccaf0ac884d57744ed57e2f26b51446de2d7	2018-03-29 16:53:20 +00:00