7 commits

Author	SHA1	Message	Date
Stephen Niedzielski	ae44042cbf	Hygiene: add assertion messages ... Change-Id: Ic0a47bd468532824e8648c3f6371cc403896603c	2018-05-08 15:55:23 -05:00
Stephen Niedzielski	57762e0417	Hygiene: favor const ... Bug: T165036 Change-Id: I17d374eaac6627ca6a8ba178862b2a9cff2538c0	2018-03-21 10:44:24 +00:00
Stephen Niedzielski	0bee0906d4	Hygiene: replace var with let and const ... eslint \ --cache \ --max-warnings 0 \ --report-unused-disable-directives \ --fix \ src tests Change-Id: I051275126ae7fa9affd16c2504017c0584f2d9c7	2018-03-20 14:14:02 -05:00
Stephen Niedzielski	ece4670710	Hygiene: use arrow for anonymous functions ... In some places, the arrow function seems more natural. This patch approximates the following with manual amendments: find \ -not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \ -iname \*.js| xargs -rd\\n sed -ri 's%function\s*(\([^)]*\))%\1 =>%g' Files to focus on were identified with: rg -slg\!/resources/dist/ -g\!/i18n/ -g\!/doc/ 'this|self|arguments|bind|call|apply|new'| xargs -rd\\n git difftool -y Bug: T165036 Change-Id: Ic66b6000b8fc000f9bfde39749f9cfa69924a13c	2018-03-20 09:27:08 -05:00
Stephen Niedzielski	a67466acc0	Hygiene: replace obvious function methods ... Replace easily identifiable object functions with method syntax: find \ -not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \ -iname \*.js| xargs -rd\\n sed -ri 's%:\s*function\s*(\([^)]*\))%\1%g' Bug: T165036 Change-Id: I90693ee99a6a36dff820dd5ae6f6000429763058	2018-03-20 09:27:07 -05:00
joakin	e6081106f1	Use EcmaScript modules instead of common.js modules ... Why: Because they are the approved standard by TC39 and Ecma for JavaScript modules. Changes: * Wrap mw-node-qunit in run.js to register babel to transpile modules for node v6 * Change all sources in src/ to use ES modules * Change constants.js to be able to run without jQuery.bracketedDevicePixelRatio given ES modules are hoisted to the top by spec so we can't patch globals before importing it * Change all tests in tests/node-qunit/ to use ES modules * Drop usage of mock-require given ES modules are easy to stub with sinon Additional changes: * Rename tests/node-qunit/renderer.js to renderer.test.js to follow the convention of all the other files * Make npm run test:node run only .test.js test files so that it doesn't run the stubs.js or run.js file. Bug: T171951 Change-Id: I17a0b76041d5e2fd18e2d54950d9d7c0db99a941	2017-07-31 23:05:44 +00:00
joakin	d2d7ab10fa	Test: Migrate changeListener.test.js to node-qunit ... Change-Id: Ib6d5156d2f1bc56c113866ed0510966586d9ca07	2017-02-20 20:01:01 +01:00