wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-15 11:46:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
1760 commits 279 branches 0 tags 65 MiB
Commit graph

6 commits

Author SHA1 Message Date
Nick Ray c64497e5df Upgrade elint-config-wikimedia (drop eslint-plugin-qunit) 
The following upgrade was made:

eslint-config-wikimedia | 0.8.1 | 0.9.0

The upgrade of eslint-config-wikimedia removes the need of
eslint-plugin-qunit as a peerDependency because it is now a hard
dependency [1] so it was removed in our package.json.

It appears the biggest change in the upgrade was the use of separate
profiles [2]. Given this, our root .eslintrc.json was updated to extend
from 'wikimedia/client'.

Several test files were flagged by the upgraded linter and were fixed in
this patch. Additionally, our build file was flagged for having too many
statements on one line. This rule was turned off in .eslintrc.es5.json

[1] https://github.com/wikimedia/eslint-config-wikimedia/blob/master/package.json#L48
[2] https://github.com/wikimedia/eslint-config-wikimedia/blob/master/CHANGELOG.md#090--2018-11-19

Bug: T209314
Change-Id: I29db72e77f04a327bc9c2b558c6d53849287bb80
 2018-12-13 14:12:06 -07:00
jdlrobson 10e6e25091 Upgrade eslint-config-wikimedia 
* Force arrow-parens
* Disable no-prototype-builtins for time being
* Drop unnecessary maxlen rule

Change-Id: Iceb0fe47354a5753202d2c6ad9e1a9c76791f744
 2018-07-13 07:42:12 -05:00
Stephen Niedzielski 007cc5ab7c Hygiene: favor string templates over concatenation 
Update the ESLint config to favor ES6 strings where variables or string
concatenation is used and fix *all* offenders automatically via:

  eslint \
    --cache \
    --max-warnings 0 \
    --report-unused-disable-directives \
    --fix \
    src tests

Change-Id: I1a9345162348e5ded21d541e7a2ce251ea72ab5a
 2018-03-21 08:05:55 -05:00
Stephen Niedzielski 0bee0906d4 Hygiene: replace var with let and const 
eslint \
    --cache \
    --max-warnings 0 \
    --report-unused-disable-directives \
    --fix \
    src tests

Change-Id: I051275126ae7fa9affd16c2504017c0584f2d9c7
 2018-03-20 14:14:02 -05:00
jdlrobson 535149c16c Upgrade schema and log the required fields 
This change updates the schema and begins to log
additional information such as source_namespace, id
and title. This information is provided inside the
boot action.

Additional changes:
* Allow camel case in bundle artifact

Bug: T184793
Bug: T186728
Change-Id: I425ffecc018bef2958d0dfe957a40a065e3e6c56
 2018-02-26 10:25:30 -08:00
jdlrobson 90fbd093c8 Run eslint on compiled assets to ensure code is es5 compatible 
It doesn't feel great but it does the trick.

Bug: T174570
Change-Id: I76d1b81625a77df0d926c2da714bcab606a28b8d
 2017-09-07 12:30:33 +02:00