Stephen Niedzielski
57762e0417
Hygiene: favor const
...
Bug: T165036
Change-Id: I17d374eaac6627ca6a8ba178862b2a9cff2538c0
2018-03-21 10:44:24 +00:00
Stephen Niedzielski
0bee0906d4
Hygiene: replace var with let and const
...
eslint \
--cache \
--max-warnings 0 \
--report-unused-disable-directives \
--fix \
src tests
Change-Id: I051275126ae7fa9affd16c2504017c0584f2d9c7
2018-03-20 14:14:02 -05:00
Stephen Niedzielski
ece4670710
Hygiene: use arrow for anonymous functions
...
In some places, the arrow function seems more natural. This patch
approximates the following with manual amendments:
find \
-not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \
-iname \*.js|
xargs -rd\\n sed -ri 's%function\s*(\([^)]*\))%\1 =>%g'
Files to focus on were identified with:
rg -slg\!/resources/dist/ -g\!/i18n/ -g\!/doc/ 'this|self|arguments|bind|call|apply|new'|
xargs -rd\\n git difftool -y
Bug: T165036
Change-Id: Ic66b6000b8fc000f9bfde39749f9cfa69924a13c
2018-03-20 09:27:08 -05:00
Stephen Niedzielski
a67466acc0
Hygiene: replace obvious function methods
...
Replace easily identifiable object functions with method syntax:
find \
-not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \
-iname \*.js|
xargs -rd\\n sed -ri 's%:\s*function\s*(\([^)]*\))%\1%g'
Bug: T165036
Change-Id: I90693ee99a6a36dff820dd5ae6f6000429763058
2018-03-20 09:27:07 -05:00
Stephen Niedzielski
a2a743d775
Hygiene: use object shorthand where obvious
...
Approximately:
find \
-not \( \( -name node_modules -o -name .git -o -name vendor -o -name doc -o -name resources \) -prune \) \
-iname \*.js|
xargs -rd\\n sed -ri 's%(\b\S+\b)\s*:\s*\b\1\b%\1%g'
Bug: T165036
Change-Id: I48869dc93b66f908e070288eb2f035bb064993e3
2018-03-20 09:26:20 -05:00
Stephen Niedzielski
42816702eb
Hygiene: replace Mustache templates w/ ES6 strings
...
Replace Mustache.js templates with template literals. An effort was made
to minimize additional refactoring, so feel free to ask for more but it
ain't coming in this PS.
Bug: T165036
Change-Id: I4a6a1d93a2922c3a9ef3ae93c47da17a35c644f0
2018-03-20 08:06:02 -05:00
Stephen Niedzielski
674ade83e7
Hygiene: move settings dialog to separate file
...
Separate the settings dialog and settings dialog renderer into two
files.
Bug: T165036
Change-Id: I500add4b89ec8c5d1a76d7c5572f62204d61f62d
2018-03-14 21:39:39 +00:00
