wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-15 11:46:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
584 commits 279 branches 0 tags 65 MiB
Commit graph

15 commits

Author SHA1 Message Date
Baha aba43fd560 Switch to Schema:Popups revid 15597282 
Bug: T131315
Change-Id: I2ed18e00afb3e355327b417e68e5930b46d49086
 2016-05-24 14:26:46 -07:00
Baha 72dd872781 Add QUnit test for ext.popups.settings 
Test pieces that make sense, everything else is already
covered in cucumber tests. See the following commit for more
info: I55f311b6b8845e6ebf4cc5698758afd1f9042a45.

Bug: T133025
Change-Id: I474c1569494601ae5865dcfba22ea728220ff8df
 2016-04-28 16:13:20 -04:00
Prateek Saxena ba919e5d0a settings: Remove navPopEnabled property 
This doesn't need to be a property. Its being used exactly once, and
because we try to test for NavigationPopup's availability so soon we
mostly get an incorrect answer.

Moving the condition to the render method instead. Chances of NavPop
being loaded when the settings' screen is being rendered are much
higher.

Bug: T109912
Change-Id: I3723dc1e3e9400b6ed2e0160104c849a25a71881
 2015-10-08 00:11:28 +05:30
Prateek Saxena 6eef4f325b Add jscs and jshint tasks to the Gruntfile 
Adds the jscs and jshint packages for development and their tasks in
Grunt. Also fixes all the code convention errors.

Change-Id: If1c9dfdbe22d4912d78b6a51b1292866970a85cc
 2015-09-04 13:57:52 +05:30
jenkins-bot b1dd60ccf5 Merge "Use pg.fn.disablePopups to detect and stop NavigationPopups" 2015-08-27 20:17:37 +00:00
Timo Tijhof 41c12d3f9a Remove stray ")" from the "Enable previews" link 
Follows-up dd98179a15.

Change-Id: I07b039dae272c9e66f091dd07b6e9b7d20b6d275
 2015-08-27 03:06:20 +02:00
Prateek Saxena 1270c240c9 Use pg.fn.disablePopups to detect and stop NavigationPopups 
The global disablePopups function from NavigationPopups got scoped to
pg.fn.disabledPopups at some point. We were relying on that function
to both detect and disable the gadget.

Bug: T109912
Change-Id: I3d6de60ca2a387e45675ddb04cdc45b0f967e46a
 2015-08-26 16:52:22 +05:30
Prateek Saxena 947f644991 Move all images to resources/images 
Change-Id: Iac712668baf8cefedf036c4d479687e3f5da5a46
 2015-07-18 22:27:18 +00:00
Prateek Saxena 3b82fb60d9 settings: Use .text() instead of .html() for option's label 
Bug: T88171
Change-Id: I5d4631870f916194901f897839cad4c90c2d8d01
 2015-03-24 13:37:05 +05:30
Prateek Saxena 9ab483ec6f settings: Add help dialog 
Change-Id: I5f4cf435356748a1aceb05fcaf8c8980b8267804
 2014-11-26 11:43:01 +05:30
jenkins-bot e50cf04603 Merge "Remove preventDefault from settings.open" 2014-08-25 17:51:59 +00:00
Prateek Saxena ca8b7f8658 Remove preventDefault from settings.open 
Bug: 69579
Change-Id: I6e457542060d147c35ccb2dfeade5b90f20bd2ca
 2014-08-25 18:02:46 +05:30
Prateek Saxena 13f3f1cf67 settings: Fix strings, copy and capitalization 
Addresses the issues pointed out in:
https://gerrit.wikimedia.org/r/#/c/140086/16/i18n/en.json

Discussion:
https://trello.com/c/NYQ0nMeE/101-hovercards-phase-3

Bug: 68812
Change-Id: I7b4f6d2be08a1ee20b19aec95d99a73fd4bf9d29
 2014-08-25 14:26:59 +05:30
Prateek Saxena 26962431c3 Stop showing the NavigationPopups options if it isn't available 
This got committed by accident in I374805eed0bc9f262b29474093f0357c56b42c83

Change-Id: Ic2dba3bd3b488aea97d7f3be3a56cf9f44912355
 2014-08-12 16:10:57 +05:30
Prateek Saxena dd98179a15 Add settings 
Save Hovercards enabled state in localStorage (jStorage)

Change-Id: I374805eed0bc9f262b29474093f0357c56b42c83
 2014-07-28 13:38:03 +05:30