Umherirrender
05faae63a8
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
...
Change-Id: Ia2551ff625132f0acb5cbeed8d893809438583f0
2020-11-17 23:23:29 +01:00
DannyS712
751e05160a
Fix PSR12.Properties.ConstantVisibility.NotFound
...
Bug: T253169
Change-Id: I6504b960d34726d94c79b68e186a4206a3cf386a
2020-05-19 23:38:59 +00:00
Umherirrender
a2e5bd0364
build: Remove unneeded Squiz.WhiteSpace.FunctionSpacing
...
It is already part of the default ruleset.xml
Change-Id: I26ee0c4df83360577ef08b42d5f05084c6b29ea3
2019-10-25 20:32:36 +02:00
James D. Forrester
e16143df16
build: Upgrade mediawiki-codesniffer to v28.0.0
...
Change-Id: Icd67aed448269f603dd4465f7e46eac9a64bd1a1
2019-10-15 16:13:01 -07:00
Thiemo Kreuz
e32fc4914e
Add some missing newlines to separate PHP code better
...
I believe these additional newlines all make the code easier to read.
It's easier to see what belongs together, and what is a separate thing.
I found the Squiz.WhiteSpace.FunctionSpacing sniff very helpful to
enforce this code style. We enabled this already in almost all WMDE
codebases. It is not yet part of the upstream MediaWiki rule set, but
discussed.
Change-Id: Ibdf788529b28637bf98e7940c2516852c3afcef7
2019-03-11 11:33:13 +01:00
Thiemo Kreuz
1cf4e5902b
Enable Squiz.Strings.DoubleQuoteUsage PHPCS sniff
...
The majority of this was fixed just recently via I8de42df. The sniff
makes sure all old and new code conforms to this style.
Change-Id: I8aecf3653d021fc8f86abcdc5939529864f86a48
2019-03-01 11:28:20 +01:00
Umherirrender
033cf7a795
build: Update sniff list in .phpcs.xml
...
FunctionDeclarationArgumentSpacing is now part of the default
Change-Id: I6e6638e1e115dd793b58cc18852aaaa5d282846c
2018-12-08 15:34:57 +01:00
Thiemo Kreuz
865bd524f2
Add missing "public" visibility in PopupsHooks.php
...
Public is the default, and hook handlers must be public. I assume this
was nothing but a mistake.
Change-Id: I20eedfd8c4cb954db770afdda3f373e272530b82
2018-05-20 21:13:36 +02:00
libraryupgrader
9cccf15c43
build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
...
The following sniffs are failing and were disabled:
* Squiz.Scope.MethodScope.Missing
Change-Id: I163626b66b33cb185bbcedb8f00d85890628f9dc
2017-12-30 02:19:18 +00:00
Umherirrender
0e64e6d09e
Move phpcs.xml to .phpcs.xml
...
See T177256
Change-Id: I6830e5f4d7e3fa11b95fc0d12b57b48ffbc362fd
2017-10-21 14:43:57 +02:00
