wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-24 07:34:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Wire up showing settings via footer link or cog icon

Browse source 
The changeListener is not wired up, so nothing will actually happen if you
click the link or cog. You should see redux actions flow trying to show it
though.

Change-Id: I29e629db63a4511a76c132f44f2ebf13254a4c6f
This commit is contained in:
joakin 2016-12-12 19:07:07 +01:00
parent 034f1840ab
commit e7c8f36a9f
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
resources/ext.popups/changeListeners/footerLink.js
View file

@ -57,7 +57,10 @@
return function ( prevState, state ) {
if ( $footerLink === undefined ) {
$footerLink = createFooterLink();
$footerLink.click( boundActions.showSettings );
$footerLink.click( function ( e ) {
e.preventDefault();
boundActions.showSettings();
} );
}
if ( state.preview.enabled ) {

1
resources/ext.popups/renderer.js
View file

@ -267,6 +267,7 @@
layoutPreview( preview, layout );
preview.el.hover( boundActions.previewDwell, boundActions.previewAbandon );
preview.el.find( '.mwe-popups-settings-icon' ).click( boundActions.showSettings );
preview.el.show();