From ca8b7f8658c622e27d1c881fefd9513082ee8715 Mon Sep 17 00:00:00 2001 From: Prateek Saxena Date: Mon, 18 Aug 2014 17:07:54 +0530 Subject: [PATCH] Remove preventDefault from settings.open Bug: 69579 Change-Id: I6e457542060d147c35ccb2dfeade5b90f20bd2ca --- resources/ext.popups.settings.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/resources/ext.popups.settings.js b/resources/ext.popups.settings.js index 1d2963009..6da9a98ae 100644 --- a/resources/ext.popups.settings.js +++ b/resources/ext.popups.settings.js @@ -119,7 +119,7 @@ * * @method open */ - settings.open = function ( e ) { + settings.open = function () { var h = $( window ).height(), w = $( window ).width(); @@ -131,7 +131,6 @@ .css( 'left', ( w - 600 ) / 2 ) .css( 'top', ( h - settings.$element.outerHeight( true ) ) / 2 ); - e.preventDefault(); return false; }; @@ -160,7 +159,10 @@ $( '' ) .attr( 'href', '#)' ) .text( mw.message( 'popups-settings-enable' ).text() ) - .click( settings.open ) + .click( function ( e ) { + settings.open(); + e.preventDefault(); + } ) ), $footer = $( '#footer-places, #f-list' );