wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-09-25 03:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Annotate survey link with rel=noreferrer

Browse source 
Don't leak referrer information or `window.opener` to the survey hosting
site.

Bug: T129177
Change-Id: I828bd01391bc1e034fe5655d89209b83f192b112
This commit is contained in:
Sam Smith 2016-05-11 14:02:17 +01:00
parent 0be6753836
commit dab4f55e0d
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
resources/ext.popups.renderer.article.js
View file

@ -151,6 +151,13 @@
.attr( 'href', article.surveyLink )
.attr( 'target', '_blank' )
.attr( 'title', mw.message( 'popups-send-feedback' ) )
// Don't leak referrer information to the site hosting the survey. N.B. that
// `rel=noreferrer` implies `rel=noopener`. See
// https://html.spec.whatwg.org/multipage/semantics.html#link-type-noreferrer for more
// information.
.attr( 'rel', 'noreferrer' )
.addClass( 'mwe-popups-icon mwe-popups-survey-icon' );
$footer.append( $surveyImage );
}