wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-24 07:34:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Migrate schema.test.js to node-qunit

Browse source 
Additional changes:
* Stub map with get( key, default ) which is mediawiki specific
  behavior

Change-Id: Ie6c4842604e59b5b06cc5d462216bdaa1784f558
This commit is contained in:
joakin 2017-02-28 18:32:35 +01:00
parent 5d4cc8d15a
commit d662bc62b2
2 changed files with 74 additions and 66 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

74
tests/node-qunit/schema.test.js Normal file
View file

@ -0,0 +1,74 @@
var mw = mediaWiki,
createSchema = require( '../../src/schema' );
function createStubMap() {
var m = new Map(); /* global Map */
m.get = function ( key, def ) {
return Map.prototype.get.call( m, key ) || def;
};
return m;
}
QUnit.module( 'ext.popups/schema', {
setup: function () {
this.config = createStubMap();
this.config.set( 'wgPopupsSchemaSamplingRate', 1 );
this.window = {
navigator: {
sendBeacon: function () {}
}
};
// Stub out the mw.eventLog.Schema constructor function.
mw.eventLog = { Schema: this.sandbox.stub() };
}
} );
QUnit.test( 'it should use $wgPopupsSchemaSamplingRate as the sampling rate', function ( assert ) {
assert.expect( 2 );
createSchema( this.config, this.window );
assert.ok( mw.eventLog.Schema.calledWith( 'Popups', 1 ) );
// ---
createSchema( createStubMap(), this.window );
assert.ok(
mw.eventLog.Schema.calledWith( 'Popups', 0 ),
'If $wgPopupsSchemaSamplingRate isn\'t set, then the sampling rate should be 0.'
);
} );
QUnit.test( 'it should use a 0 sampling rate when sendBeacon isn\'t supported', function ( assert ) {
var expectedArgs = [ 'Popups', 0 ];
assert.expect( 2 );
createSchema( this.config, { } );
assert.deepEqual( mw.eventLog.Schema.getCall( 0 ).args, expectedArgs );
// ---
createSchema( this.config, {
navigator: {
sendBeacon: 'NOT A FUNCTION'
}
} );
assert.deepEqual( mw.eventLog.Schema.getCall( 1 ).args, expectedArgs );
} );
QUnit.test( 'it should use a 0 sampling rate in a unit testing environment', function ( assert ) {
assert.expect( 1 );
this.window.QUnit = {};
createSchema( this.config, this.window );
assert.ok( mw.eventLog.Schema.calledWith( 'Popups', 0 ) );
} );

66
tests/qunit/ext.popups/schema.test.js
View file

@ -1,66 +0,0 @@
( function ( mw ) {
QUnit.module( 'ext.popups/schema', {
setup: function () {
this.config = new mw.Map();
this.config.set( 'wgPopupsSchemaSamplingRate', 1 );
this.window = {
navigator: {
sendBeacon: function () {}
}
};
// Stub out the mw.eventLog.Schema constructor function.
this.sandbox.stub( mw.eventLog, 'Schema', function () {} );
}
} );
QUnit.test( 'it should use $wgPopupsSchemaSamplingRate as the sampling rate', function ( assert ) {
assert.expect( 2 );
mw.popups.createSchema( this.config, this.window );
assert.ok( mw.eventLog.Schema.calledWith( 'Popups', 1 ) );
// ---
mw.popups.createSchema( new mw.Map(), this.window );
assert.ok(
mw.eventLog.Schema.calledWith( 'Popups', 0 ),
'If $wgPopupsSchemaSamplingRate isn\'t set, then the sampling rate should be 0.'
);
} );
QUnit.test( 'it should use a 0 sampling rate when sendBeacon isn\'t supported', function ( assert ) {
var expectedArgs = [ 'Popups', 0 ];
assert.expect( 2 );
mw.popups.createSchema( this.config, { } );
assert.deepEqual( mw.eventLog.Schema.getCall( 0 ).args, expectedArgs );
// ---
mw.popups.createSchema( this.config, {
navigator: {
sendBeacon: 'NOT A FUNCTION'
}
} );
assert.deepEqual( mw.eventLog.Schema.getCall( 1 ).args, expectedArgs );
} );
QUnit.test( 'it should use a 0 sampling rate in a unit testing environment', function ( assert ) {
assert.expect( 1 );
this.window.QUnit = {};
mw.popups.createSchema( this.config, this.window );
assert.ok( mw.eventLog.Schema.calledWith( 'Popups', 0 ) );
} );
}( mediaWiki ) );