wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-27 17:00:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use :not() CSS pseudo-class instead of jQuery .not() filter in selector

Browse source 
The old version would iterate over all links on the page (try that on
[[Barack Obama]]), the new one should be optimized by the browser and
poly-filled by jQuery if unavailable.

We can't do `:not(.extiw, .image, .new, .internal, [title=""])` –
while some browsers support it, CSS specification doesn't allow
compount selectors inside :not().

Change-Id: I0e4b18752905604ebf1b7f41a9b7ac2edd8b42e0
This commit is contained in:
Bartosz Dziewoński 2014-04-22 15:55:43 +02:00 committed by Yuvipanda
parent 31e42fd85a
commit c3e3df7905
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
resources/ext.popups.core.js
View file

@ -428,12 +428,7 @@
// Remove title attribute to remove the default yellow tooltip // Remove title attribute to remove the default yellow tooltip
// Put the title back after the hover // Put the title back after the hover
$( '#mw-content-text a' ) $( '#mw-content-text a:not(.extiw):not(.image):not(.new):not(.internal):not([title=""])' )
.not( '.extiw' )
.not( '.image' )
.not( '.new' )
.not( '.internal' )
.not( '[title=""]' )
.on( 'mouseenter focus', function () { .on( 'mouseenter focus', function () {
$( this ) $( this )
.attr( 'data-original-title', $( this ).attr( 'title' ) ) .attr( 'data-original-title', $( this ).attr( 'title' ) )