Merge "Add SVG border using polyline element"

src/ui/templates/popup/popup.less

@@ -300,3 +300,36 @@
 		}
 	}
 }
+
+// Position the SVG border
+.mwe-popups-is-tall {
+	polyline {
+		.mwe-popups-translate( 0, 0 );
+	}
+	&.flipped-x-y {
+		polyline {
+			.mwe-popups-translate( 0, -8px );
+		}
+	}
+	&.flipped-x {
+		polyline {
+			.mwe-popups-translate( 0, 8px );
+		}
+	}
+}
+
+.rtl .mwe-popups-is-tall {
+	polyline {
+		.mwe-popups-translate( -100%, 0 );
+	}
+	&.flipped-x-y {
+		polyline {
+			.mwe-popups-translate( -100%, -8px );
+		}
+	}
+	&.flipped-x {
+		polyline {
+			.mwe-popups-translate( -100%, 8px );
+		}
+	}
+}

src/ui/thumbnail.js

@@ -120,6 +120,18 @@ export function createThumbnailElement(
 	const nsSvg = 'http://www.w3.org/2000/svg',
 		nsXlink = 'http://www.w3.org/1999/xlink';
 
+	// We want to visually separate the image from the summary
+	// Given we use an SVG mask, we cannot rely on border to do this
+	// and instead must insert a polyline element to visually separate
+	const line = document.createElementNS( nsSvg, 'polyline' );
+	const isTall = className.indexOf( 'not-tall' ) === -1;
+	const points = isTall ? [ 0, 0, 0, height ] :
+		[ 0, height - 1, width, height - 1 ];
+
+	line.setAttribute( 'stroke', 'rgba(0,0,0,0.1)' );
+	line.setAttribute( 'points', points.join( ' ' ) );
+	line.setAttribute( 'stroke-width', 1 );
+
 	const $thumbnailSVGImage = $( document.createElementNS( nsSvg, 'image' ) );
 	$thumbnailSVGImage[ 0 ].setAttributeNS( nsXlink, 'href', url );
 	$thumbnailSVGImage
@@ -139,5 +151,6 @@ export function createThumbnailElement(
 		} )
 		.append( $thumbnailSVGImage );
 
+	$thumbnail.append( line );
 	return $thumbnail;
 }

tests/node-qunit/ui/thumbnail.test.js

@@ -234,36 +234,51 @@ QUnit.test( 'createThumbnail - insecure URL', ( assert ) => {
 } );
 
 QUnit.test( 'createThumbnailElement', ( assert ) => {
-	const className = 'thumb-class',
+	const
 		url = 'https://thumbnail.url',
 		x = 25,
 		y = 50,
 		thumbnailWidth = 200,
 		thumbnailHeight = 250,
 		width = 500,
-		height = 300,
-		$thumbnail = createThumbnailElement(
+		height = 300;
+
+	[
+		{
+			className: 'mwe-popups-is-not-tall',
+			expectedPoints: '0 299 500 299',
+			// eslint-disable-next-line max-len
+			expectedHTML: '<image href="https://thumbnail.url" class="mwe-popups-is-not-tall" x="25" y="50" width="200" height="250"></image>'
+		},
+		{
+			className: 'mwe-popups-is-tall',
+			expectedPoints: '0 0 0 300'
+		}
+	].forEach( ( { className, expectedPoints, expectedHTML }, i ) => {
+		const $thumbnail = createThumbnailElement(
 			className, url, x, y, thumbnailWidth, thumbnailHeight,
 			width, height );
 
+		// Simplify HTML image test
+		const points = $thumbnail.find( 'polyline' ).attr( 'points' );
+		$thumbnail.find( 'polyline' ).remove();
+		assert.strictEqual( points, expectedPoints, 'Points are correct.' );
+
+		if ( expectedHTML ) {
 			assert.strictEqual(
 				$thumbnail.html(),
-		'<image href="https://thumbnail.url" class="thumb-class" x="25" y="50" width="200" height="250"></image>',
+				expectedHTML,
 				'Thumbnail HTML is correct.'
 			);
+		}
+		if ( i === 0 ) {
 			assert.strictEqual(
 				$thumbnail.attr( 'xmlns' ),
 				'http://www.w3.org/2000/svg',
 				'SVG namespace is correct.'
 			);
-	assert.strictEqual(
-		Number.parseFloat( $thumbnail.attr( 'height' ) ),
-		height,
-		'SVG height is correct.'
-	);
-	assert.strictEqual(
-		Number.parseFloat( $thumbnail.attr( 'width' ) ),
-		width,
-		'SVG width is correct.'
-	);
+			assert.equal( $thumbnail.attr( 'height' ), height, 'SVG height is correct.' );
+			assert.equal( $thumbnail.attr( 'width' ), width, 'SVG width is correct.' );
+		}
+	} );
 } );