wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-13 17:56:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hygiene: Rename action constants for consistency

Browse source 
No place for a single COG action, or verbs in past tense. Use NAME_ACTION like
in other actions.

Change-Id: I58b6756ce1e46eca10fe5ae03639b1dbcdc9907c
This commit is contained in:
joakin 2016-12-12 18:17:41 +01:00
parent 6444dcc7a6
commit b33ba3d954
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
resources/ext.popups/actions.js
View file

@ -17,9 +17,9 @@
PREVIEW_INTERACTIVE: 'PREVIEW_INTERACTIVE',
PREVIEW_SHOW: 'PREVIEW_SHOW',
PREVIEW_CLICK: 'PREVIEW_CLICK',
COG_CLICK: 'COG_CLICK',
SETTINGS_DIALOG_RENDERED: 'SETTINGS_DIALOG_RENDERED',
SETTINGS_DIALOG_CLOSED: 'SETTINGS_DIALOG_CLOSED',
SETTINGS_SHOW: 'SETTINGS_SHOW',
SETTINGS_HIDE: 'SETTINGS_HIDE',
EVENT_LOGGED: 'EVENT_LOGGED'
},
FETCH_START_DELAY = 500, // ms.
@ -246,7 +246,18 @@
*/
actions.showSettings = function () {
return {
type: 'COG_CLICK'
type: types.SETTINGS_SHOW
};
};
/**
* Represents the user closing the settings dialog and saving their settings.
*
* @return {Object}
*/
actions.settingsDialogClosed = function () {
return {
type: types.SETTINGS_HIDE
};
};