From addb8a02d72663701f7bfd8a615c95916c06f00d Mon Sep 17 00:00:00 2001 From: Func Date: Tue, 18 Jan 2022 05:03:07 +0000 Subject: [PATCH] Use null for default user options value of beta features The new soft auto-enroll logic of BetaFeatures requires user options default to null or no default values since it needs to save opt-out values. Unfortunately, BetaFeatures can't maintain default options itself, since the GetBetaFeaturePreferences hook is coupled with User, can't be run in the handler of UserGetDefaultOptions hook. All the user options will be handled by BetaFeatures carefully, no unnecessary values will be saved (no regression of T291748). Needed by change I93af61153ec3c2cd3ec7686fe88067eed6766b5a, and they should be merged in the same deploy train. Bug: T260870 Change-Id: I1e9a91eed2e2eb22ce42f8d79b7183c505f1df7d --- extension.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extension.json b/extension.json index 060c3dbbc..ade893fe9 100644 --- a/extension.json +++ b/extension.json @@ -233,7 +233,7 @@ "includes/ServiceWiring.php" ], "DefaultUserOptions": { - "popupsreferencepreviews": 0, + "popupsreferencepreviews": null, "popups-reference-previews": 0 }, "manifest_version": 2