wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-15 03:34:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Deeply extend prev state for test correctness

Browse source 
As it is, that test is passing the same previous state and current state
because extend by default only copies one level deep, resulting in the
manual mutation mutating both prev and current state.

This passes because the change listener always sets the link visibility
from the current state regardless of the previous state (it is doing
redundant work, but not too much).

Change-Id: I8cf125cc4f6833fbce0fe14bdcb4ef550c7e8450
This commit is contained in:
joakin 2016-11-30 19:22:54 +01:00
parent eb981bcd72
commit ac264001f6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/qunit/ext.popups/footerLinkChangeListener.test.js
View file

@ -63,7 +63,7 @@
// --- // ---
prevState = $.extend( {}, this.state ); prevState = $.extend( true, {}, this.state );
this.state.preview.enabled = true; this.state.preview.enabled = true;
this.footerLinkChangeListener( prevState, this.state ); this.footerLinkChangeListener( prevState, this.state );