wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-24 07:34:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Correctly log the 'dismissed' action when hovering over another link"

Browse source
This commit is contained in:
jenkins-bot 2016-06-03 11:08:02 +00:00 committed by Gerrit Code Review
parent 049ae039a7 a8e8ca489f
commit 9f91cd6d3c
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/ext.popups.renderer/desktopRenderer.js
View file

@ -106,7 +106,8 @@
}
mw.popups.render.currentLink = link;
// Set the log data only after the current link is set, otherwise, functions like
// closePopup will use the new log data when closing an old popup.
logData = {
pageTitleHover: mw.popups.getTitle( linkHref ),
dwellStartTime: dwellStartTime,
@ -261,6 +262,11 @@
}
} );
mw.track( 'ext.popups.schemaPopups', $.extend( {}, logData, {
action: 'dismissed',
totalInteractionTime: Math.round( mw.now() - logData.dwellStartTime )
} ) );
if ( closeTimer ) {
closeTimer.abort();
}
@ -314,10 +320,6 @@
*/
mw.popups.render.leaveActive = function () {
closeTimer = mw.popups.render.wait( mw.popups.render.POPUP_CLOSE_DELAY ).done( function () {
mw.track( 'ext.popups.schemaPopups', $.extend( {}, logData, {
action: 'dismissed',
totalInteractionTime: Math.round( mw.now() - logData.dwellStartTime )
} ) );
mw.popups.render.closePopup();
} );
};