wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-27 17:00:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable error logging for missing settings cog on references beta feature

Browse source 
Bug: T346404
Change-Id: I36b1759f6d00ff6ce584a1bc1ac68dedd633fc6a
This commit is contained in:
Jon Robson 2023-09-15 09:49:02 -07:00
parent e69309d5a2
commit 961778b3c5
4 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js vendored
View file

Binary file not shown.

BIN
resources/dist/index.js.map.json vendored
View file

Binary file not shown.

6
src/ui/renderer.js
View file

@ -312,6 +312,12 @@ export function bindBehavior( preview, behavior ) {
behavior.showSettings( event ); behavior.showSettings( event );
} ); } );
} else if (
preview.el.classList.contains( 'mwe-popups-type-reference' ) &&
mw.config.get( 'wgPopupsReferencePreviewsBetaFeature' )
) {
// The reference preview when in beta feature doesn't have a settings cog (T346404).
return;
} else { } else {
const err = new Error( 'Page previews: No settings button found in preview.' ); const err = new Error( 'Page previews: No settings button found in preview.' );
mw.errorLogger.logError( err, 'error.web-team' ); mw.errorLogger.logError( err, 'error.web-team' );

4
webpack.config.js
View file

@ -118,8 +118,8 @@ module.exports = ( env, argv ) => ( {
// Minified uncompressed size limits for chunks / assets and entrypoints. Keep these numbers // Minified uncompressed size limits for chunks / assets and entrypoints. Keep these numbers
// up-to-date and rounded to the nearest 10th of a kibibyte so that code sizing costs are // up-to-date and rounded to the nearest 10th of a kibibyte so that code sizing costs are
// well understood. Related to bundlesize minified, gzipped compressed file size tests. // well understood. Related to bundlesize minified, gzipped compressed file size tests.
maxAssetSize: 46.7 * 1024, maxAssetSize: 46.8 * 1024,
maxEntrypointSize: 46.7 * 1024, maxEntrypointSize: 46.8 * 1024,
// The default filter excludes map files but we rename ours. // The default filter excludes map files but we rename ours.
assetFilter: ( filename ) => !filename.endsWith( srcMapExt ) assetFilter: ( filename ) => !filename.endsWith( srcMapExt )