wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-15 03:34:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing escaping for jQuery ID selector

Browse source 
We run into this issue already one time, see Ifb5fe89 (T214710). The
exact same applies here.

The effect of this bug is that for certain references (typically ones
with a colon character in their name) the "jump down" link will be
broken.

Change-Id: Ic6723bd910cb5e5e1e1872ce39f2e271012245de
This commit is contained in:
Thiemo Kreuz 2019-03-13 15:31:16 +01:00
parent d816f230b5
commit 932271b6db
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js vendored
View file

Binary file not shown.

BIN
resources/dist/index.js.map.json vendored
View file

Binary file not shown.

5
src/ui/templates/referencePreview/referencePreview.js
View file

@ -7,7 +7,8 @@ import { escapeHTML } from '../templateUtil';
// Known citation type strings currently supported with icons and messages.
const KNOWN_TYPES = [ 'book', 'journal', 'news', 'web' ],
mw = mediaWiki;
mw = mediaWiki,
$ = jQuery;
/**
* @param {ext.popups.PreviewModel} model
@ -51,7 +52,7 @@ export function renderReferencePreview(
if ( model.sourceElementId ) {
$el.find( '.mwe-popups-read-link' ).on( 'click', ( event ) => {
event.stopPropagation();
$( `#${ model.sourceElementId } > a` ).trigger( 'click' );
$( `#${ $.escapeSelector( model.sourceElementId ) } > a` ).trigger( 'click' );
} );
}