Merge "Add new reference type "note" without an icon"

This commit is contained in:
jenkins-bot 2021-02-16 11:29:02 +00:00 committed by Gerrit Code Review
commit 8c575f9cef
7 changed files with 16 additions and 5 deletions

View file

@ -211,6 +211,7 @@
"popups-refpreview-book",
"popups-refpreview-journal",
"popups-refpreview-news",
"popups-refpreview-note",
"popups-refpreview-web",
"popups-refpreview-collapsible-placeholder"
],

View file

@ -27,6 +27,7 @@
"popups-refpreview-book": "Book reference",
"popups-refpreview-journal": "Journal reference",
"popups-refpreview-news": "News reference",
"popups-refpreview-note": "Note",
"popups-refpreview-web": "Web reference",
"popups-refpreview-collapsible-placeholder": "This reference includes a graphic which does not fit in the preview.",
"popups-refpreview-user-preference-label": "Reference previews (get quick previews of footnotes)",

View file

@ -37,6 +37,7 @@
"popups-refpreview-book": "Heading for a popup previewing a citation from a book.\n{{Identical|Book}}",
"popups-refpreview-journal": "Heading for a popup previewing a citation from a journal.\n{{Identical|Journal}}",
"popups-refpreview-news": "Heading for a popup previewing a citation from the news.\n{{Identical|News}}",
"popups-refpreview-note": "Heading for a popup previewing a footnote.\n{{Identical|Note}}",
"popups-refpreview-web": "Heading for a popup previewing a citation from a website.\n{{Identical|Website}}",
"popups-refpreview-collapsible-placeholder": "Placeholder text for collapsible tables, templates, or other large elements inside of a reference.",
"popups-refpreview-user-preference-label": "Label for the user option to enable or disable reference preview popups",

Binary file not shown.

Binary file not shown.

View file

@ -21,7 +21,7 @@ const templateHTML = `
</div>`;
// Known citation type strings currently supported with icons and messages.
const KNOWN_TYPES = [ 'book', 'journal', 'news', 'web' ];
const KNOWN_TYPES = [ 'book', 'journal', 'news', 'note', 'web' ];
const LOGGING_SCHEMA = 'event.ReferencePreviewsPopups';
let isTracking = false;
@ -49,6 +49,7 @@ export function renderReferencePreview(
// * popups-refpreview-book
// * popups-refpreview-journal
// * popups-refpreview-news
// * popups-refpreview-note
// * popups-refpreview-reference
// * popups-refpreview-web
title = escapeHTML( mw.msg( titleMsg ) );
@ -56,10 +57,12 @@ export function renderReferencePreview(
$el.find( '.mwe-popups-title-placeholder' )
.replaceWith( title );
// The following classes are used here:
// * mw-icon-reference-reference
// * mw-icon-reference-unknown
// * mw-icon-reference-generic
// * mw-icon-reference-disambiguation
// * mw-ui-icon-reference-generic
// * mw-ui-icon-reference-book
// * mw-ui-icon-reference-journal
// * mw-ui-icon-reference-news
// * mw-ui-icon-reference-note
// * mw-ui-icon-reference-web
$el.find( '.mw-ui-icon' )
.addClass( `mw-ui-icon-reference-${type}` );
$el.find( '.mw-parser-output' )

View file

@ -24,6 +24,11 @@
/* align narrow icon with the text */
margin-left: -2px;
}
// There is currently no "reference-note" icon specified in extension.json
&.mw-ui-icon-reference-note {
display: none;
}
}
.mwe-popups-extract {