Merge "Replace rare {!…} and {?…} JSDoc syntax"

src/preview/model.js

@@ -29,12 +29,12 @@ export { previewTypes };
  * @property {string} url The canonical URL of the page being previewed
  * @property {string} languageCode
  * @property {string} languageDirection Either "ltr" or "rtl"
- * @property {?Array} extract `undefined` if the extract isn't
+ * @property {Array|undefined} extract `undefined` if the extract isn't
  *  viable, e.g. if it's empty after having ellipsis and parentheticals
  *  removed; this can be used to present default or error states
  * @property {string} type One of the previewTypes.TYPE_… constants.
- * @property {?Object|undefined} thumbnail
- * @property {?number|undefined} pageId
+ * @property {Object|undefined} thumbnail
+ * @property {number|undefined} pageId
  *
  * @global
  */
@@ -46,10 +46,10 @@ export { previewTypes };
  * @param {string} url The canonical URL of the page being previewed
  * @param {string} languageCode
  * @param {string} languageDirection Either "ltr" or "rtl"
- * @param {?Array} extract
+ * @param {Array|undefined|null} extract
  * @param {string} type
- * @param {?Object} [thumbnail]
- * @param {?number} [pageId]
+ * @param {Object} [thumbnail]
+ * @param {number} [pageId]
  * @return {PreviewModel}
  */
 export function createModel(
@@ -80,9 +80,9 @@ export function createModel(
 /**
  * Creates an empty preview model.
  *
- * @param {!string} title
- * @param {!string} url
- * @return {!PreviewModel}
+ * @param {string} title
+ * @param {string} url
+ * @return {PreviewModel}
  */
 export function createNullModel( title, url ) {
 	return createModel( title, url, '', '', [], '' );

src/reducers/preview.js

@@ -4,10 +4,10 @@ import nextState from './nextState';
 /**
  * Reducer for actions that modify the state of the preview model
  *
- * @param {?Object} state before action
- * @param {!Object} action Redux action that modified state.
+ * @param {Object|undefined} state before action
+ * @param {Object} action Redux action that modified state.
  *  Must have `type` property.
- * @return {!Object} state after action
+ * @return {Object} state after action
  */
 export default function preview( state, action ) {
 	if ( state === undefined ) {

tests/node-qunit/stubs.js

@@ -55,10 +55,10 @@ export function createStubExperiments( bucket ) {
  * Creates a **minimal** stub that can be used in place of an instance of
  * `mw.Title`.
  *
- * @param {!number} namespace
- * @param {!string} prefixedDb, e.g. Foo, or File:Bar.jpg
+ * @param {number} namespace
+ * @param {string} prefixedDb, e.g. Foo, or File:Bar.jpg
  * @param {string|null} [fragment]
- * @return {!Object}
+ * @return {Object}
  */
 export function createStubTitle( namespace, prefixedDb, fragment = null ) {
 	return {