wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-28 09:20:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Hygiene: Remove unnecessary IIFE in changeListeners/render.js"

Browse source
This commit is contained in:
jenkins-bot 2017-02-20 17:30:02 +00:00 committed by Gerrit Code Review
parent cafe6d4edb 27d1ad8318
commit 8097314077
3 changed files with 18 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js vendored
View file

Binary file not shown.

BIN
resources/dist/index.js.map vendored
View file

Binary file not shown.

12
src/changeListeners/render.js
View file

@ -1,23 +1,21 @@
( function ( mw ) { var renderer = require( '../renderer' );
/** /**
* Creates an instance of the render change listener. * Creates an instance of the render change listener.
* *
* @param {ext.popups.PreviewBehavior} previewBehavior * @param {ext.popups.PreviewBehavior} previewBehavior
* @return {ext.popups.ChangeListener} * @return {ext.popups.ChangeListener}
*/ */
module.exports = function ( previewBehavior ) { module.exports = function ( previewBehavior ) {
var preview; var preview;
return function ( prevState, state ) { return function ( prevState, state ) {
if ( state.preview.shouldShow && !preview ) { if ( state.preview.shouldShow && !preview ) {
preview = mw.popups.renderer.render( state.preview.fetchResponse ); preview = renderer.render( state.preview.fetchResponse );
preview.show( state.preview.activeEvent, previewBehavior ); preview.show( state.preview.activeEvent, previewBehavior );
} else if ( !state.preview.shouldShow && preview ) { } else if ( !state.preview.shouldShow && preview ) {
preview.hide(); preview.hide();
preview = undefined; preview = undefined;
} }
}; };
}; };
}( mediaWiki ) );