wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-23 15:16:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

mw.popups.isEnabled should always return boolean

Browse source 
Mismatch between documentation and function signature

Bug: T346106
Change-Id: I43e0efc67b76496aab228b3f971db795662337cf
This commit is contained in:
Jon Robson 2023-10-16 10:12:07 -07:00
parent 90a829179c
commit 614039b7df
3 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js vendored
View file

Binary file not shown.

BIN
resources/dist/index.js.map.json vendored
View file

Binary file not shown.

2
src/integrations/mwpopups.js
View file

@ -20,7 +20,7 @@ export default function createMwPopups( store, registerModel, registerPreviewUI,
* @return {boolean} If Page Previews are currently active
*/
isEnabled: function isEnabled() {
return store.getState().preview.enabled[ previewTypes.TYPE_PAGE ];
return !!store.getState().preview.enabled[ previewTypes.TYPE_PAGE ];
},
/**
* @stable Do not remove properties in the type PopupModule without providing backwards