wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-24 07:34:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hygiene: Avoid touching internal state in tests

Browse source 
Test what mw.popups.haveCheckinActionsBeenSetup guards against so that
it doesn't have to be touched during the associated test.

Bug: T147314
Change-Id: I315e0782a0e3b1d04878f1ee6f538e54531f7df5
This commit is contained in:
Sam Smith 2017-01-04 11:07:31 +00:00
parent 4afa1958a0
commit 60adbd0831
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/qunit/ext.popups/checkin.test.js
View file

@ -82,9 +82,9 @@
assert.expect( 1 );
checkin.haveCheckinActionsBeenSetup = true;
checkin.setupActions( actionSpy );
assert.ok( spy.notCalled, 'setVisibleTimeout has not been called.' );
checkin.setupActions( actionSpy );
assert.strictEqual( spy.callCount, 1, 'setVisibleTimeout is only ever called once.' );
} );
QUnit.test( 'checkin actions are setup correctly', function ( assert ) {