wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-09-23 10:21:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable MediaWiki.Commenting.FunctionComment.MissingParamTag sniff

Browse source 
Changes also solve the MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
sniff

Bug: T168384
Change-Id: Idd80e42943a57a4b6211c50a4aac2f1d20e6232d
This commit is contained in:
Piotr Miazga 2017-07-12 22:27:44 +02:00 committed by Phuedx
parent b8e7a79a20
commit 5b62bc625b
4 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
includes/EventLogging/MWEventLogger.php
View file

@ -38,6 +38,7 @@ class MWEventLogger implements EventLogger {
/**
* Module constructor.
* @param Config $config MediaWiki configuration
* @param ExtensionRegistry $registry MediaWiki extension registry
*/
public function __construct( Config $config, ExtensionRegistry $registry ) {
$this->config = $config;

8
includes/PopupsHooks.php
View file

@ -57,7 +57,7 @@ class PopupsHooks {
* Add Page Previews options to user Preferences page
*
* @param User $user User whose preferences are being modified
* @param array $prefs Preferences description array, to be fed to a HTMLForm object
* @param array &$prefs Preferences description array, to be fed to a HTMLForm object
*/
static function onGetPreferences( User $user, array &$prefs ) {
$context = PopupsContext::getInstance();
@ -114,7 +114,7 @@ class PopupsHooks {
}
/**
* @param array $vars Array of variables to be added into the output of the startup module
* @param array &$vars Array of variables to be added into the output of the startup module
*/
public static function onResourceLoaderGetConfigVars( array &$vars ) {
$conf = PopupsContext::getInstance()->getConfig();
@ -134,7 +134,7 @@ class PopupsHooks {
* * `wgPopupsConflictsWithNavPopupGadget' - The server's notion of whether or not the
* user has enabled conflicting Navigational Popups Gadget.
*
* @param array $vars variables to be added into the output of OutputPage::headElement
* @param array &$vars variables to be added into the output of OutputPage::headElement
* @param OutputPage $out OutputPage instance calling the hook
*/
public static function onMakeGlobalVariablesScript( array &$vars, OutputPage $out ) {
@ -149,7 +149,7 @@ class PopupsHooks {
/**
* Register default preferences for popups
*
* @param array $wgDefaultUserOptions Reference to default options array
* @param array &$wgDefaultUserOptions Reference to default options array
*/
public static function onUserGetDefaultOptions( &$wgDefaultUserOptions ) {
$wgDefaultUserOptions[ PopupsContext::PREVIEWS_OPTIN_PREFERENCE_NAME ] =

2
includes/UserPreferencesChangeHandler.php
View file

@ -80,7 +80,7 @@ class UserPreferencesChangeHandler {
* @param array $formData Form data submitted by user
* @param PreferencesForm $form A preferences form
* @param User $user Logged-in user
* @param boolean $result Variable defining is form save successful
* @param boolean &$result Variable defining is form save successful
* @param array $oldUserOptions Old user options array
*/
public static function onPreferencesFormPreSave(

2
phpcs.xml
View file

@ -1,9 +1,7 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
<exclude name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>