From 58563f44be5fac710bbf01ab420690a6abf0e100 Mon Sep 17 00:00:00 2001 From: Jon Robson Date: Tue, 30 Jan 2024 08:33:51 -0800 Subject: [PATCH] Do not search for elements if no previews have been registered The findNearestEligibleTarget method is now being called with an empty array and thus an empty string as a selector Follow up to I5f293a134521f086c9f62babb9d06cd9c51d7d47 Bug: T355933 Bug: T356186 Bug: T356193 Change-Id: I3af44ae65d5097fc44744838a4edb07552568b17 (cherry picked from commit 51059828bfb6e1e084ad8613bea7e15837aa64dd) --- resources/dist/index.js | Bin 40797 -> 40837 bytes resources/dist/index.js.map.json | Bin 201289 -> 201398 bytes src/preview/model.js | 7 +++++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/resources/dist/index.js b/resources/dist/index.js index 4ad92f064acb13f412b0a19a678edc77a99a6775..f4fb8178ba48eaaa904c3fd92698488ca2b5cfd6 100644 GIT binary patch delta 150 zcmcb+kEwM((}uY%DVb>+d8Iiying{IdA4b#dC4W2`FR?tn$!Q?>(xNzwO-+c#qRls3 mQklhz)YMWn@^p%HfC_6KGF@ J|LN!y0{~IvCgK19 diff --git a/resources/dist/index.js.map.json b/resources/dist/index.js.map.json index 734dd7725d34640dbdf0fa03eec35dec3db211a6..64873424741ab01dbe1da83a5ae7f151fd8e4c7e 100644 GIT binary patch delta 4130 zcmZu!U2Ggz71jndB+xkNPtrQgKc!Bxlg{k_E-h*Ay)&Mj9k18p^=9i7+HUOi{{PwQ z{ZoWrplS2dHoYZI(=J^DWR z1>AKQOIOHFzKrHsu0E}~K-AJqR0WD={B+Ta7r+L~hUP#_j5sKGPB0PxEn-#^En)C{ zcn)(A2nk(n^45p~N%*H(D-BwBO)N%XL+Jk*m&vuh{OkXM)PixXS!9!4)d zW;ITNTlQR&?%J)B6p28ESrZ*z=557VIjQ9tE0C?M&~oT-SFu**KVCfG8_3OPzVWqi zQEPBW6dx%b=@<1$48a10%nQhcGe`VJ0lm~!x&j4Ez?6#IWzMWhB2rl{AwM{CaIJ#! zET2VEjfbc@EL(#w5IkLI^NbZyOThFC_}b=13fU_6a$vnWNv=0|FO65y%afqcQVuxL zS-hIUD^LJn=g|Xaw17r!V?nzIj_yc)>!k@_Lw@(AN7oYQoN4*V$AxBvlk-tdm2N1v zvVkm8Jv{>-r*5LMbeNhVze16hIYVNHLq1uaYK50PX0^?_gN}G%vVc@bUK)sbb}FUa z553k@$t#^gxm-*pUY?2v=TKixkQ-CT$i}eo>@wv;=+u~A$40SyE4NXsw*1-4X(zfw z7t&aLNy=X&r_p< zy~H^~A7XEq9WjFMWXtXGh?u=+9v=Iv7vx#RrKV@928eGU(GdW3wwP{xpv{;!v@?(C>fCIOk_$cGN;Tt@+TLL?uaO20*Ru{gYw@OCbsIRO3aoP z<)K%O`4YEhUK#i89OkirL24|gyhQn{$nU(mZwwp*@o7SpbW6VX>fW_M?$ac)G2g(e zU;~RRsAFl65>>3GDxn2j5$82$mHUAV_6*)src`s(&ES+~M|jyaL=9#l%uDXfXpx*5 zE^1zc>nVUYIr-Z7L;4cxcl|S<-l~d{hxzdmviDkGUnft84H000$g%)YCGyMH0*7Jl zJA_tPL@V?RW_nqTRrnc{D`*RhB?EHb#RGf&CqAuD&9N21R>`x7eD-2xTZhcwx%0=1 zd$#v8%GxO!qoDlX#mK=Cf(`be%`#n_ujw?-tC+$DgtlwT+1I@Xf>d^ega~LXJCg6e zt{*jMa1zjdI6q2PCZ5Cqa&X6D7T^N3GYiS>a{qR~E|5c<0TqC~-;|F%WvFJN`ed{c zB%s2ZIaRGZvwLCy`NvsZqU-=V=xOoWNmd6VKqw6W$QX+&B;2;W)U<$o_7(1$Jxsn-Yn*{o3pv!8%7R8!3MO&BEGStb}NsvA%i+(isNG|{bWL~3t7y1fSY14(Za zR0EVg|K?yzRN+QMe*9*jV9X&xKZJYsHbXH z2}%H`H`Ks|nkY{pGa$fw$kJz+#-01LHHoHK_C7HQ0HLe|??^2p*Gj-NZ)5#QvFbti zLX@-e$8SCGFvTmHg5m|2?#BCXIddqL56Qn@oi<9?mtr;orH38C3&R(fuqFYu&SQ#P zDq%_xw^Il-MBj940gr{dlT(Lo2kZ-&QQS+JT>;}T@eXZrt`>woHoNlUYyL$;X-pBK zXS;9@LdjCFVT3>?BD_wku&9x(Vi`aH++HdvFeuJ|uvk(JRxWBSPF?CS8~8Xdb3xg> zzSkF#=dVBEi^^YJKMX&%{&juNPAUMjoJHBgayI!u9=dU4#}J2=7FjUVvzqeR8+#@y zv>?p+X`9Ib8bdZuzzdG4$IJM;MgW9dyRmD_M$HEDr#D(w914vc%10Z&pllj8e3?5U zo-Xs&2E99pNirw}`QB%@NZEep#8+An64b%qZTW|HwEZP0Ak?V2F*-fkhBN(XTIm*b z`N+-jW9k)lL$Jz#zg@oi454C-ei~&Oq=Dt|2PJa{vT*a;dyQ$F{>8*1J@PHWl1y+K z;bW;TKf1X)9-h`JfKqKfn4w4#O4%wXgQu0q1ponEk^4X@v^XjG3zVQ$K_SG*{Hvb=CIlxW; delta 4057 zcmZu!-EUmQ71u&(lPED1lsHuR0zw?J7xsI-+ltVcx!2e0_4WFCz1i3j5*x3*-yinc z`z2RyRh0lqAj!~}0EGZSeW_5TNad-2Kr2hGLu2U_v6 zvvX$V%sFR%=XcKi+57u{aeMzyC&Rv$PKBTO#&9AigO;I$D9Mmz*h2MH*fK1!s^1Nt z@rCrS!r%67=#j`ZUqs)E{MHxMo6+ouMjctCJ_DhTbnQBe&TqI{OigaSe$cm)Y z|BjB`@=sDI$_l?C9e@o&*p)?6;#PI-`LR8BC$B$$%Bn3I zj6yRacA)KIQ@OC5dR#S^}+K6UY%kA;_w zhD2Co-&^Dhx+>$pYRU~WMx3IA43k|G~Jy+NK$hwEs<2@#`Px`AKAhL z{^YYHs>x7^q9w8wj1agjQ=WRCKN{7gbp=_Yd55u!%&@I(;IT#p(D=P1Qc4H z0jcO59i5^hO3-qiEJ*d2=u&&IWZZ{oy015181vQi?H5jNjgxVvh1bFErFuoO@o~v7 zTJy}x4znb60~rjdx=G5MFh732!=9I=AmOS+JVl=0iVnHLYMb>GsdmGB14$7)2g1C# zFl9Wbglc-h^YeyWOfS4Roe0j8zMNt+rb$6I27n2>%<)hG2B5oY)3$sgxARy{{ks>P zRCI+8IQ04)fXO->ArJ1Zz|19Dc84p7>AFM|DZ(ax{mKfG5V+QzmjY8Ap44QL-E!;a z=t?`9hIdHR${eO@%5%9-=?GVO$VR3xn~V_7rv)6D(tmj=G6GoR#WQTMSktF39UG|? z>D3n)t+;glQgCmN0AjAHzP@tl@CeVulDA=~?_7Gs7t|kL3OwDP#WrVhfFUS1Qa0fU z7UaU-CkAQuN>P`TcQoAHGS^Ne381J%% zOl;a%7OApq>EB#A^8n}or!q+rsuKzxW=~4`<}1gNP12!em?)eED_m&MJ}4x&(xiKeaor^@y1P~X{gtD>aXoVN(7r^K zo=F5{T|ag8@YgGN&!{Y=XZuCIsHgK+9~(`susZ)NfM`_}M%eC->uXm-$69%w>})By zv}H{tcDMZDYUnhQbCoHDfM+QXzIpw_o3hv-RyA_QH;p; z^{=l7&I}mJNlAfJQ+=Wmkx5LFwK<%zgoR86+(by9(Z}xxn_wShKK6kP&+Ajq3|2VI zigG+-l;CYe)^jv-kneU^^-)!jJ>eA&1^6N_R9Dv73^%5KuAkb|^7taA|DjJF3KN&b zVJwVTl`*!-jp`>~ee&6%ORBPLlgI#M6E%L#s&y6S)V^6qK9 z`0A0zQNI9+zL^@IB5*8JJ=C@vV4W8nzuu57ZEj zO$O6*T@OYjY+JC0=_G-zCjnUs(K6#9R-`yOaUK@HZwM~p;s}@4=jK|>f=f{@BxhaWS3aif4p(<1b7ZH ztH|z`+yja!>qFZo_V&`W33X6EvwdWrXT!P~$mr$mvkwf?hP5vH=>i#CQsBMqADoV- z7&#qTUmybt7Q&Gpg10*|IJGK!i=;3vWBR$*&W2avKnL@lN+Q2)VTXw4qGraAsU@PY z83X(_kgL_%sBG$wUONo-`s-_to~qZ_#q8%?O0LfJOhDXDwV7v@qdIi+Alfqf=E?gj zpd09FGnax0hd29sqMW2|M1OWOR2Xo@c888p5NaKHwoGK(^Q2X(3#u=x6I2WeHBVZ1 zFat|Wb4G1=!hj8@En=*&>`V=0i9@{s+P?hy6I*dkl8Q_se5i7M25m|9sbZ>ibHF6A zygmzCt(6d&3@CB}W)j2z2n*NPh?(T+7Z%Y+q5J!PDJwuFLfUoB?g6F`wWCmrHxByC zOf0)1K3-D+YCBa(mATE^UDV%u zM{3hv(m~Xc>-r~eng=?J${g*=hxC8moLTY{hpV{=P=M0yhB0ChEexb}8S}(78QqbG zID=G7)~RVV-XCiUzZ z&cTN)dl@EH6EL{S{i&+ZAeI9-0qa)$o>|MY*sNAOkOhjw3xw2^u)zb=QO^hUi*FxA z%KZ54Z{bVkPj8)CfkPd2#w6*=^c2xO4Ml<)p;`=>9xb8cS)ZsSRUpq5YHF_!(9;<=hT z3AfH|Y-VG|=z&{`Ne*e2Of1%zM$#S+EO-Sx9YSA2Su8is6WcrE{GF4j0U=a==<83U zyL$88XSW73#2m%(A~yqGvychS5cRB7xlB{709~)ndW7R;Y#qG$`bVYs*eInfb3;if?2M@N0fE`GY{`|#7vds44_IJ^Jem9PF6?k%r{ diff --git a/src/preview/model.js b/src/preview/model.js index 88972a8e2..f5e2937dd 100644 --- a/src/preview/model.js +++ b/src/preview/model.js @@ -123,8 +123,11 @@ const elementMatchesSelector = ( element, selector ) => { * @return {HTMLElement|null} */ export function findNearestEligibleTarget( element ) { - const selector = selectors.join( ', ' ); - return element.closest( selector ); + if ( selectors.length ) { + const selector = selectors.join( ', ' ); + return element.closest( selector ); + } + return null; } /**