wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-23 15:16:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not search for elements if no previews have been registered

Browse source 
The findNearestEligibleTarget method is now being called with an
empty array and thus an empty string as a selector

Follow up to
I5f293a134521f086c9f62babb9d06cd9c51d7d47

Bug: T355933
Bug: T356186
Bug: T356193
Change-Id: I3af44ae65d5097fc44744838a4edb07552568b17
(cherry picked from commit 51059828bf)
This commit is contained in:
Jon Robson 2024-01-30 08:33:51 -08:00 committed by James D. Forrester
parent f8c6d42218
commit 58563f44be
3 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js vendored
View file

Binary file not shown.

BIN
resources/dist/index.js.map.json vendored
View file

Binary file not shown.

7
src/preview/model.js
View file

@ -123,8 +123,11 @@ const elementMatchesSelector = ( element, selector ) => {
* @return {HTMLElement|null}
*/
export function findNearestEligibleTarget( element ) {
const selector = selectors.join( ', ' );
return element.closest( selector );
if ( selectors.length ) {
const selector = selectors.join( ', ' );
return element.closest( selector );
}
return null;
}
/**