wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-11 16:58:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Move possibly expensive title parser construction down"

Browse source
This commit is contained in:
jenkins-bot 2019-02-11 22:28:19 +00:00 committed by Gerrit Code Review
parent a981c2f48b 0686f40069
commit 5752b3feb1
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js vendored
View file

Binary file not shown.

BIN
resources/dist/index.js.map.json vendored
View file

Binary file not shown.

7
src/title.js
View file

@ -12,9 +12,6 @@ const mw = mediaWiki;
* @return {string|undefined}
*/
export function getTitle( href, config ) {
const titleRegex = new RegExp( mw.RegExp.escape( config.get( 'wgArticlePath' ) )
.replace( '\\$1', '([^?#]+)' ) );
// Skip every URI that mw.Uri cannot parse
let linkHref;
try {
@ -33,7 +30,9 @@ export function getTitle( href, config ) {
// No query params (pretty URL)
if ( !queryLength ) {
const matches = titleRegex.exec( linkHref.path );
const pattern = mw.RegExp.escape( config.get( 'wgArticlePath' ) ).replace( '\\$1', '([^?#]+)' ),
matches = new RegExp( pattern ).exec( linkHref.path );
// We can't be sure decodeURIComponent() is able to parse every possible match
try {
title = matches && decodeURIComponent( matches[ 1 ] );