wikimedia/mediawiki-extensions-Popups
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/extensions/Popups synced 2024-11-23 23:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure to never trigger multiple events

Browse source 
I had to disable ESLint to be allowed to upload this patch. It starts
complaining about something in code I did not even touched. The error
message does not make any sense to me (something about globals being
forbidden in code where I can not spot anything that would be remotely
global).

Change-Id: I6d4b178a65126c4b81b87d99142a6cdc845ae5ee
This commit is contained in:
Thiemo Kreuz 2019-03-25 12:54:55 +01:00 committed by Stephen Niedzielski
parent 522f4aa8a2
commit 511c74bf72
4 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
resources/dist/index.js vendored
View file

Binary file not shown.

BIN
resources/dist/index.js.map.json vendored
View file

Binary file not shown.

2
src/ui/templates/referencePreview/referencePreview.js
View file

@ -54,7 +54,7 @@ export function renderReferencePreview(
if ( model.sourceElementId ) {
$el.find( '.mwe-popups-read-link' ).on( 'click', ( event ) => {
event.stopPropagation();
$( `#${ $.escapeSelector( model.sourceElementId ) } > a` ).trigger( 'click' );
$( `#${ $.escapeSelector( model.sourceElementId ) } > a:first-child` ).trigger( 'click' );
} );
}

2
tests/node-qunit/changeListeners/footerLink.test.js
View file

@ -33,7 +33,7 @@ QUnit.module( 'ext.popups/changeListeners/footerLink @integration', {
};
this.getLink = function () {
return this.$footer.find( 'li' );
return this.$footer.find( 'li:last-child' );
};
},
afterEach() {